feat: refactor core Exif processing logic into @exifi/core - #47
Merged
Conversation
jeremy-code
commented
Sep 5, 2026
jeremy-code
commented
Owner
- Create @exifi/core package
- Remove Rational class and mapRationalArray function, rely only on RationalObject
- Refactor logic to handle string and Rational values for serialized Exif data
- Add initializeGpsEntries action
- In general, handle string and Rational values as an input whenever possible
…zed Exif data - serializeExifData now returns a string for ASCII values and RationalObject[] for RATIONAL and SRATIONAL values, instead of always returning number[] - ExifEntryAddEditor and ExifEntryEditor now handle string values for ASCII format and RationalObject[] for RATIONAL and SRATIONAL formats, instead of always using number[] - @exifi-core/exif/date/* has a simpler format - Remove leaflet dependency in @exifi/core, move formatLatLng, formatLatLngAsGeoUri, and formatLatLngAsOsmUrl to #lib/leaflet - Update add editor to assume string value when format is undefined - Add initializeGpsEntries action in @exifi-core/exif/actions/initializeGpsEntries to initialize GPS entries in exifDataObject if they are missing
✅ Deploy Preview for exifi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Owner
Author
|
Deploy Preview: https://deploy-preview-47--exifi.netlify.app/ Viewer: works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.