Hash branch views

[i-h8-github]

class App
  hash_branch('test') do |r|
    r.is 'hello' do
      render 'hello' # looks for `views/test/hello.erb`, as per docs
    end
    r.is 'hello-again' do
      render 'fragments/hello' # looks for `views/fragments/hello.erb`, despite the lack of leading `/`
    end
  end
end

Is this intended behavior? I can't help but feel that the behavior of the leading / (or lack thereof) should be consistent, i.e. the hello-again branch as written above should be looking for views/test/fragments/hello.erb unless one specifically asks it to look from the root view directory with leading /.

The behavior above is identical between render and view.

[jeremyevans]

This is expected. If you include a slash in your view, the view_subdirs plugin assumes you are providing the full path, so you would need test/fragments/hello. Otherwise, it would be more difficult to use templates from one hash branch in a different hash branch.

It's possible we could make this configurable, or add a different plugin for the behavior you want.

[jeremyevans]

To be consistent with filesystem paths, a leading slash should look for a view at the root of the filesystem. You can think of the current paths without a leading slash as relative to the view directory. The fact that views with a leading slash do not look at the root of the filesystem could be considered an inconsistency by some people. You could make the argument that the views directory should be treated as the root of the filesystem for these operations, but that's not valid as .. allows going above the views directory (as long as the template file is under an allowed path).

That being said, it should be possible to allow the behavior you want as an option.

[i-h8-github]

Well, I know I, for one, would appreciate that behavior, though you do raise some interesting points. For me, it just feels weird that file and /file are different, but dir/file and /dir/file aren't.

[jeremyevans]

I added a view_subdir_leading_slash plugin to the master branch. Can you test it out and let me know if it will work for you?

[i-h8-github]

Thank you for your work and attention.

I don't know if the plugin installation process is supposed to be any more involved than dropping the relevant file into roda's plugins directory. In any case, I don't get any complaints when adding plugin :view_subdir_leading_slash to my code.

However, as far as I can tell so far, the behavior isn't any different from before.

Perhaps I have done something wrong.

Also, I feel I should clarify something:

If I am reading the intended behavior of the new plugin correctly, this would make all view searches relative to the current branch or else from the root view directory with a leading slash. That certainly seems useful in its own way, but the behavior I originally brought up and sought to change was the way each hash_branch would automatically look for a view in a matching view subdirectory unless a slash is present, which makes intuitive sense to me as it sort of makes the hash_branch the "current working directory", so to speak. I only desired to make the behavior consistent unto itself.

Below is a hash_branch that illustrates the current behavior and (my) expected behavior:

class App
  hash_branch('test') do |r|
    r.is 'hello' do
      # current behavior: looks for `views/test/hello.erb`
      # also desired behavior
      render 'hello'
    end
    r.is 'root-hello' do
      # current behavior: looks for `views/hello.erb`
      # also desired behavior
      render '/hello'
    end
    r.is 'sub-hello' do
      # current behavior: looks for `views/fragments/hello.erb`
      # desired behavior: looks for `views/test/fragments/hello.erb`, consistent with 'hello' path
      render 'fragments/hello'
    end
    r.is 'root-sub-hello' do
      # current behavior: looks for `views/fragments/hello.erb`
      # desired behavior: as above, consistent with behavior of 'root-hello' path
      render '/fragments/hello'
    end
    r.on 'sub-branch' do
      r.is 'hello' do
        # current behavior: looks for `views/test/hello.erb`
        # also desired behavior
        render 'hello'
      end
    end
  end
end

[jeremyevans]

You need to update to the master branch, not just copy the plugin file. This required changes to the view_options plugin.