Gitmoot: Follow-up: address the coordinator round-1 review on jerryfane/tendwire

[jerryfane]

WHAT:
Addressed all five coordinator round-1 review items for PR #11. Full suite is green; no commit, push, or merge was performed.

WHY:
Gitmoot finalized this implementation from a task worktree.

CHANGES:

• Committed changes from /root/.gitmoot/worktrees/jerryfane--tendwire/adhoc-8c610303

RESULTS:

• Full suite with TENDWIRE_BENCHMARK_HERDRES_ROOT=/root/herdres: 2871 passed, 2 skipped.
• Focused daemon, CLI, connector, and release tests: 224 passed, 1 skipped.
• Manual scripts/tendwired_lifecycle_smoke.sh: passed.
• Python compileall, Bash syntax, and git diff whitespace checks: passed.

RISK:
Review the generated diff before merging.

TASK:
adhoc-8c610303

AGENTS:

• tendwire-sol-impl

RAW FINAL REVIEW OUTPUT:

Addressed all five coordinator round-1 review items for PR #11. Full suite is green; no commit, push, or merge was performed.

[jerryfane]

Agent: tendwire-sol-impl
Runtime: codex
Job: local-implement-tendwire-sol-impl-18c3deda1453c573

Decision: implemented
Summary: Addressed all five coordinator round-1 review items for PR #11. Full suite is green; no commit, push, or merge was performed.

Changes Made

• Added daemon version and PID to ping/health responses and surfaced holder/current identities in startup-conflict errors.
• Moved periodic reclaim onto an isolated daemon worker so a blocked database operation cannot prevent bounded shutdown.
• Added the distinct peer_validation_failed error code and made the startup guard fail closed on credential-validation errors.
• Documented the Herdres-owned production service-template split and softened the stale-process diagnosis to match observed evidence.
• Added regression coverage for identity responses, conflict reporting, peer-validation classification, bounded periodic shutdown, and installation documentation.

Tests Run

• Full suite with TENDWIRE_BENCHMARK_HERDRES_ROOT=/root/herdres: 2871 passed, 2 skipped.
• Focused daemon, CLI, connector, and release tests: 224 passed, 1 skipped.
• Manual scripts/tendwired_lifecycle_smoke.sh: passed.
• Python compileall, Bash syntax, and git diff whitespace checks: passed.

Raw runtime output was retained in local Gitmoot state and is not posted here.

[jerryfane]

Coordinator review (Fable) — APPROVED. All items mutation-verified: version+PID in ping/health surfaced in the startup-conflict message (forged-pair protection included); periodic tick moved off the accept loop to a bounded single-worker executor (blocked-callback test proves stop stays deadline-driven); peer-validation failures now typed PEER_VALIDATION_FAILED and fail closed (the silent stale-misclassification repro is fixed); diagnosis honestly hedged; template-ownership split documented and pinned by tests. Round-1 content bundled and spot-verified intact. 205/205 targeted green, full serial suite clean. The one remaining gap is cross-repo (herdres template lacks the directives) — closed by luminexord/herdres#157. Merging.