Skip to content

Reduce "with" stack consumption by 1. #2430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2018
Merged

Reduce "with" stack consumption by 1. #2430

merged 1 commit into from
Jul 18, 2018

Conversation

@zherczeg
Copy link
Member

@zherczeg zherczeg commented Jul 18, 2018

No description provided.

@zherczeg
Reduce with stack consumption by 1.
dbd52e4 
JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
LaszloLango
LaszloLango approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@LaszloLango LaszloLango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rerobika
rerobika approved these changes Jul 18, 2018
View reviewed changes
Copy link
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informally)

robertsipka
robertsipka approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robertsipka robertsipka merged commit 9513f37 into jerryscript-project:master Jul 18, 2018
@zherczeg zherczeg deleted the optimize_with branch July 19, 2018 03:33
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
@legendecas
jerry: reduce with stack consumption by 1
cb02bdc 
Picked from upstream jerryscript-project/jerryscript#2430
yorkie pushed a commit to yodaos-project/ShadowNode that referenced this pull request Nov 30, 2018
@legendecas @yorkie
jerry: implement ES2015 class feature (part II.) (#428)
3c4bb93 
Refs: jerryscript-project/jerryscript#2431
Refs: jerryscript-project/jerryscript#2496
Refs: jerryscript-project/jerryscript#2485
Refs: jerryscript-project/jerryscript#2530
Refs: jerryscript-project/jerryscript#2547
Refs: jerryscript-project/jerryscript#2436
Refs: jerryscript-project/jerryscript#2467
Refs: jerryscript-project/jerryscript#2481
Refs: jerryscript-project/jerryscript#2408
Refs: jerryscript-project/jerryscript#2430
Refs: jerryscript-project/jerryscript#2439
Refs: jerryscript-project/jerryscript#2588
@zherczeg zherczeg mentioned this pull request Mar 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertsipka robertsipka robertsipka approved these changes

@LaszloLango LaszloLango LaszloLango approved these changes

@rerobika rerobika rerobika approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zherczeg @robertsipka @LaszloLango @rerobika