Skip to content

Add explicit casts to enum-to-integer conversions #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2018
Merged

Add explicit casts to enum-to-integer conversions #2467

merged 1 commit into from
Aug 13, 2018

Conversation

@akosthekiss
Copy link
Member

@akosthekiss akosthekiss commented Aug 11, 2018

Clang 6 is more picky about implicit conversions and complains
about loss of presicion and/or change of signedness.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu

@akosthekiss
Add explicit casts to enum-to-integer conversions
1136e93 
Clang 6 is more picky about implicit conversions and complains
about loss of presicion and/or change of signedness.

JerryScript-DCO-1.0-Signed-off-by: Akos Kiss akiss@inf.u-szeged.hu
@akosthekiss
Copy link
Member Author

akosthekiss commented Aug 11, 2018

Tested on Ubuntu 18.04.1 LTS (Linux 4.15.0 x86_64) with the following command:

CC=clang-6.0 tools/build.py --clean --lto=off --error-messages=on --external-context=on \
  --jerry-debugger=on --line-info=on --logging=on --mem-stats=on --profile=es2015-subset \
  --show-opcodes=on --show-regexp-opcodes=on --snapshot-exec=on --snapshot-save=on \
  --valgrind=on --vm-exec-stop=on --jerry-libc=off --debug

zherczeg
zherczeg approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@zherczeg zherczeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yichoi
yichoi approved these changes Aug 13, 2018
View reviewed changes
Copy link
Contributor

@yichoi yichoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yichoi yichoi merged commit b31e430 into jerryscript-project:master Aug 13, 2018
@akosthekiss akosthekiss deleted the conversion-clang6 branch August 13, 2018 07:59
@akosthekiss akosthekiss mentioned this pull request Aug 15, 2018
Merged
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
@legendecas
jerry: add explicit casts to enum-to-integer conversions
7b072e7 
Picked from upstream jerryscript-project/jerryscript#2467
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
@legendecas
jerry: add explicit casts to enum-to-integer conversions
c0e3112 
Picked from upstream jerryscript-project/jerryscript#2467
legendecas added a commit to yodaos-project/ShadowNode that referenced this pull request Nov 29, 2018
@legendecas
jerry: add explicit casts to enum-to-integer conversions
3961a7c 
Picked from upstream jerryscript-project/jerryscript#2467
yorkie pushed a commit to yodaos-project/ShadowNode that referenced this pull request Nov 30, 2018
@legendecas @yorkie
jerry: implement ES2015 class feature (part II.) (#428)
3c4bb93 
Refs: jerryscript-project/jerryscript#2431
Refs: jerryscript-project/jerryscript#2496
Refs: jerryscript-project/jerryscript#2485
Refs: jerryscript-project/jerryscript#2530
Refs: jerryscript-project/jerryscript#2547
Refs: jerryscript-project/jerryscript#2436
Refs: jerryscript-project/jerryscript#2467
Refs: jerryscript-project/jerryscript#2481
Refs: jerryscript-project/jerryscript#2408
Refs: jerryscript-project/jerryscript#2430
Refs: jerryscript-project/jerryscript#2439
Refs: jerryscript-project/jerryscript#2588
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zherczeg zherczeg zherczeg approved these changes

@yichoi yichoi yichoi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akosthekiss @zherczeg @yichoi