Rework op_construct. #2547
Merged
Rework op_construct. #2547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new form should be more suitable for classes. JerryScript-DCO-1.0-Signed-off-by: Zoltan Herczeg zherczeg.u-szeged@partner.samsung.com
zherczeg
force-pushed
the
rework_construct
branch
from
5ed104a to
ef12207
Compare
LaszloLango
requested changes
Oct 3, 2018
| /* 8. */ | ||
| ecma_value_t ret_value; | ||
|
|
||
| switch (type) |
Contributor
There was a problem hiding this comment.
An if-else statement fits better here than a switch
Member
There was a problem hiding this comment.
Currently it fits better but for further cases switch is more suitable.
LaszloLango
approved these changes
Oct 3, 2018
Contributor
|
LGTM |
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2547
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2547
legendecas
added a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 29, 2018
Picked from upstream jerryscript-project/jerryscript#2547
yorkie
pushed a commit
to yodaos-project/ShadowNode
that referenced
this pull request
Nov 30, 2018
Refs: jerryscript-project/jerryscript#2431 Refs: jerryscript-project/jerryscript#2496 Refs: jerryscript-project/jerryscript#2485 Refs: jerryscript-project/jerryscript#2530 Refs: jerryscript-project/jerryscript#2547 Refs: jerryscript-project/jerryscript#2436 Refs: jerryscript-project/jerryscript#2467 Refs: jerryscript-project/jerryscript#2481 Refs: jerryscript-project/jerryscript#2408 Refs: jerryscript-project/jerryscript#2430 Refs: jerryscript-project/jerryscript#2439 Refs: jerryscript-project/jerryscript#2588
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new form should be more suitable for ES5 class implementation. No binary / perf / mem change.