Skip to content

Get the typedArray's length property properly in Array.prototype.concat#3791

Merged
dbatyai merged 1 commit intojerryscript-project:masterfrom
szilagyiadam:array_concat_bug
May 25, 2020
Merged

Get the typedArray's length property properly in Array.prototype.concat#3791
dbatyai merged 1 commit intojerryscript-project:masterfrom
szilagyiadam:array_concat_bug

Conversation

@szilagyiadam
Copy link
Copy Markdown
Contributor

We should use the "length" property instead of the internal arraybuffer's length

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu

We should use the "length" property instead of the internal arraybuffer's length

JerryScript-DCO-1.0-Signed-off-by: Adam Szilagyi aszilagy@inf.u-szeged.hu
Copy link
Copy Markdown
Member

@rerobika rerobika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai added the ES2015 Related to ES2015 features label May 25, 2020
Copy link
Copy Markdown
Member

@dbatyai dbatyai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbatyai dbatyai merged commit e50e271 into jerryscript-project:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ES2015 Related to ES2015 features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants