Skip to content

Get the typedArray's length property properly in Array.prototype.concat #3791

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbatyai merged 1 commit into from
May 25, 2020
Merged

Get the typedArray's length property properly in Array.prototype.concat #3791

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions jerry-core/ecma/operations/ecma-objects.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,14 +887,6 @@ ecma_op_object_get_length (ecma_object_t *object_p, /**< the object */
return ECMA_VALUE_EMPTY;
}

#if ENABLED (JERRY_ES2015_BUILTIN_TYPEDARRAY)
if (ecma_object_is_typedarray (object_p))
{
*length_p = ecma_typedarray_get_length (object_p);
return ECMA_VALUE_EMPTY;
}
#endif /* ENABLED (JERRY_ES2015_BUILTIN_TYPEDARRAY) */

ecma_value_t len_value = ecma_op_object_get_by_magic_id (object_p, LIT_MAGIC_STRING_LENGTH);
ecma_value_t len_number = ecma_op_to_length (len_value, length_p);
ecma_free_value (len_value);
Expand Down
2 changes: 0 additions & 2 deletions tests/test262-es6-excludelist.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@
<test id="built-ins/ArrayBuffer/symbol-species-name.js"><reason></reason></test>
<test id="built-ins/Array/from/Array.from-name.js"><reason></reason></test>
<test id="built-ins/Array/of/name.js"><reason></reason></test>
<test id="built-ins/Array/prototype/concat/Array.prototype.concat_large-typed-array.js"><reason></reason></test>
<test id="built-ins/Array/prototype/concat/Array.prototype.concat_small-typed-array.js"><reason></reason></test>
<test id="built-ins/Array/prototype/copyWithin/name.js"><reason></reason></test>
<test id="built-ins/Array/prototype/entries/name.js"><reason></reason></test>
<test id="built-ins/Array/prototype/fill/name.js"><reason></reason></test>
Expand Down