Skip to content

add jest-cli to pathToJestPackgeJSON #trivial #243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2018
Merged

add jest-cli to pathToJestPackgeJSON #trivial #243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,9 @@ export function pathToJestPackageJSON(pluginSettings: IPluginSettings): string |
}

const defaultPath = normalize(join(pathToNodeModules, 'jest/package.json'))
const cliPath = normalize(join(pathToNodeModules, 'jest-cli/package.json'))
const craPath = normalize(join(pathToNodeModules, 'react-scripts/node_modules/jest/package.json'))
const paths = [defaultPath, craPath]
const paths = [defaultPath, cliPath, craPath]

for (const i in paths) {
if (existsSync(paths[i])) {
Expand Down
11 changes: 11 additions & 0 deletions tests/helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,17 @@ describe('ModuleHelpers', () => {
expect(pathToJestPackageJSON(workspace)).toBe(expected)
})

it('should return package.json when Jest-cli is installed as a dependency', () => {
const expected = path.join('..', '..', 'node_modules', 'jest-cli', 'package.json')
existsMock.mockImplementation(path => path === expected)

const workspace: any = {
rootPath: path.join('..', '..'),
pathToJest: defaultPathToJest,
}
expect(pathToJestPackageJSON(workspace)).toBe(expected)
})

it('should return package.json when React Scripts are installed as a dependency', () => {
const expected = path.join(
'..',
Expand Down