fix(nginx plugin): Put mime.types where nginx.conf expects it (#2908)#2909
Open
jefft wants to merge 1 commit into
Open
fix(nginx plugin): Put mime.types where nginx.conf expects it (#2908)#2909jefft wants to merge 1 commit into
jefft wants to merge 1 commit into
Conversation
…-com#2908) nginx starts with -p $NGINX_PATH_PREFIX, where -p means "set the prefix path". However this only affects the runtime path (for directives `root`, `error_log`, `access_log` etc). Relative configuration directives, like `include mime.types;`, are still resolved relative to `nginx.conf`. Therefore mime.types must go in `{{ .DevboxDir }}`, not `{{ .Virtenv }}`. Fixes jetify-com#2908
jefft
force-pushed
the
jefft/nginx-plugin-fix-2908
branch
from
58b64c8 to
237a410
Compare
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nginx starts with
-p $NGINX_PATH_PREFIX, where -p means "set the prefix path". However this only affects the runtime path (for directivesroot,error_log,access_logetc). Relative configuration directives, likeinclude mime.types;, are still resolved relative tonginx.conf. Thereforemime.typesmust go in{{ .DevboxDir }}, not{{ .Virtenv }}.Fixes #2908
How was it tested?
nginx now comes up on port 8081, whereas previously it died with
open() "/tmp/testnginx/devbox.d/nginx/mime.types" failed.Community Contribution License
All community contributions in this pull request are licensed to the project
maintainers under the terms of the
Apache 2 License.
By creating this pull request, I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 License as stated in
the
Community Contribution License.