Skip to content

Comments

Update copyright to cert-manager project#3500

Merged
jetstack-bot merged 2 commits intocert-manager:masterfrom
meyskens:update-copy
Dec 15, 2020
Merged

Update copyright to cert-manager project#3500
jetstack-bot merged 2 commits intocert-manager:masterfrom
meyskens:update-copy

Conversation

@meyskens
Copy link
Contributor

@meyskens meyskens commented Dec 8, 2020

What this PR does / why we need it:
This updates the copyright to The cert-manager contributors` to follow the CNCF donation and pending repo move outside of jetstack

Release note:

Change copyright owner to `The cert-manager Authors`

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@jetstack-bot jetstack-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Dec 8, 2020
@jetstack-bot jetstack-bot added area/acme Indicates a PR directly modifies the ACME Issuer code area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code needs-kind Indicates a PR lacks a `kind/foo` label and requires one. area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/api Indicates a PR directly modifies the 'pkg/apis' directory approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ca Indicates a PR directly modifies the CA Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing area/vault Indicates a PR directly modifies the Vault Issuer code size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 8, 2020
@meyskens
Copy link
Contributor Author

meyskens commented Dec 9, 2020

@JoshVanL i'd like to propose the award for touching most area's in the codebase in 1 PR 😂

@meyskens
Copy link
Contributor Author

meyskens commented Dec 9, 2020

/kind cleanup

@jetstack-bot jetstack-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 9, 2020
Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @meyskens

A couple of things:

  • I thought when we discussed this the other day, in slack, we concluded that it should be "The cert-manager Authors." in keeping with the Kubernetes boilerplate and because we distinguish between authors of code and contributors such as issue reporters etc.

  • I'd also want to double check the significance of the "Copyright YEAR". My understanding is that the the year should match the year that the file came into existence so it's clear that the copyright covers the whole history of the file...

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another thing I notice is that there are some non Jetstatck LICENCE files in the repo:

find . -type f -iname license 
./logo/LICENSE
./pkg/issuer/acme/dns/util/LICENSE
./pkg/issuer/acme/dns/cloudflare/LICENSE
./pkg/issuer/acme/dns/azuredns/LICENSE
./pkg/issuer/acme/dns/route53/LICENSE
./pkg/issuer/acme/dns/clouddns/LICENSE

With different copyright names. What do we do with those?

Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
@meyskens
Copy link
Contributor Author

The cert-manager Authors

Updated that!

I'd also want to double check the significance of the "Copyright YEAR"

We did change copyrights in the past, i have updated it all now as the copyright owner changed. The historic copyright is already enforced by it having a licence in the Git history

With different copyright names. What do we do with those?

Well be good to have some legal people look into the logo, others seem to be those because we 1:1 copied then which then the licence would be fair to keep

Copy link
Member

@wallrj wallrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 15, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: meyskens, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot jetstack-bot merged commit cdc53b6 into cert-manager:master Dec 15, 2020
@jetstack-bot jetstack-bot added this to the v1.2 milestone Dec 15, 2020
@meyskens meyskens deleted the update-copy branch December 15, 2020 10:21
@munnerz
Copy link
Member

munnerz commented Dec 20, 2020

We did change copyrights in the past, i have updated it all now as the copyright owner changed. The historic copyright is already enforced by it having a licence in the Git history

Not too sure if this is correct 🤔 it also means anyone wanting to review the licenses we make use of would have to trawl every revision to be safe. Would it make sense to keep these as is, or alternatively move them to a third_party directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/acme/dns01 Indicates a PR modifies ACME DNS01 provider code area/acme/http01 Indicates a PR modifies ACME HTTP01 provider code area/acme Indicates a PR directly modifies the ACME Issuer code area/api Indicates a PR directly modifies the 'pkg/apis' directory area/ca Indicates a PR directly modifies the CA Issuer code area/monitoring Indicates a PR or issue relates to monitoring area/testing Issues relating to testing area/vault Indicates a PR directly modifies the Vault Issuer code dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants