Update copyright to cert-manager project#3500
Update copyright to cert-manager project#3500jetstack-bot merged 2 commits intocert-manager:masterfrom
Conversation
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
|
@JoshVanL i'd like to propose the award for touching most area's in the codebase in 1 PR 😂 |
|
/kind cleanup |
wallrj
left a comment
There was a problem hiding this comment.
Hey @meyskens
A couple of things:
-
I thought when we discussed this the other day, in slack, we concluded that it should be "The cert-manager Authors." in keeping with the Kubernetes boilerplate and because we distinguish between authors of code and contributors such as issue reporters etc.
-
I'd also want to double check the significance of the "Copyright YEAR". My understanding is that the the year should match the year that the file came into existence so it's clear that the copyright covers the whole history of the file...
wallrj
left a comment
There was a problem hiding this comment.
Another thing I notice is that there are some non Jetstatck LICENCE files in the repo:
find . -type f -iname license
./logo/LICENSE
./pkg/issuer/acme/dns/util/LICENSE
./pkg/issuer/acme/dns/cloudflare/LICENSE
./pkg/issuer/acme/dns/azuredns/LICENSE
./pkg/issuer/acme/dns/route53/LICENSE
./pkg/issuer/acme/dns/clouddns/LICENSE
With different copyright names. What do we do with those?
Signed-off-by: Maartje Eyskens <maartje@eyskens.me>
Updated that!
We did change copyrights in the past, i have updated it all now as the copyright owner changed. The historic copyright is already enforced by it having a licence in the Git history
Well be good to have some legal people look into the logo, others seem to be those because we 1:1 copied then which then the licence would be fair to keep |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: meyskens, wallrj The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Not too sure if this is correct 🤔 it also means anyone wanting to review the licenses we make use of would have to trawl every revision to be safe. Would it make sense to keep these as is, or alternatively move them to a |
What this PR does / why we need it:
This updates the copyright to The cert-manager contributors` to follow the CNCF donation and pending repo move outside of jetstack
Release note: