Refactor ACME client construction into dedicated ACME package#797
Merged
jetstack-bot merged 1 commit intocert-manager:masterfrom Aug 7, 2018
Merged
Refactor ACME client construction into dedicated ACME package#797jetstack-bot merged 1 commit intocert-manager:masterfrom
jetstack-bot merged 1 commit intocert-manager:masterfrom
Conversation
jetstack-bot
added
release-note-none
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
wallrj
added a commit
to wallrj/cert-manager
that referenced
this pull request
Mar 20, 2024
…uests This code existed in cert-manager once before and I'm reviving it. Here's the history: * Added: cert-manager#422 * Moved: cert-manager#432 * Obsoleted: cert-manager#797 * Deleted: cert-manager#966 Signed-off-by: Richard Wall <richard.wall@venafi.com>
taraspos
pushed a commit
to gravitational/cert-manager
that referenced
this pull request
Sep 6, 2024
…uests This code existed in cert-manager once before and I'm reviving it. Here's the history: * Added: cert-manager#422 * Moved: cert-manager#432 * Obsoleted: cert-manager#797 * Deleted: cert-manager#966 Signed-off-by: Richard Wall <richard.wall@venafi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Creates a package
pkg/acmethat is responsible for instantiating ACME clients from Issuers.This is in order to support #788 and make the implementation simpler.
Again, similar to other PRs, this should have zero net-effect to the behaviour of cert-manager
Release note:
/cc @kragniz