disco: re-enable secret sending by default#787
Merged
SgtCoDFish merged 1 commit intomasterfrom Apr 20, 2026
Merged
Conversation
We got confirmation from the DisCo team that the encryption we're doing works as expected. As such, the next release of the DisCo agent should enable the secret sending by default, as we'd planned. Signed-off-by: Ashley Davis <ashley.davis@cyberark.com>
Member
|
I'm not sure how to test this. Should I just approve the PR? |
Contributor
Author
It's essentially automatically tested; we can see that the ark-test-e2e job passed fine and sent secret values (which is all visible in the logs: https://github.com/jetstack/jetstack-secure/actions/runs/23482967716/job/68331198823#step:7:1560) Without this change, secret values won't have been sent automatically, but we can see that in the e2e they were. So beyond reviewing the helm changes, I don't see much more to review. |
inteon
approved these changes
Apr 20, 2026
Contributor
inteon
left a comment
inteon
left a comment
There was a problem hiding this comment.
Based on what @SgtCoDFish said: this was approved by management & security.
I only reviewed the code, not the solution as a whole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got confirmation from the DisCo team that the encryption we're doing works as expected. As such, the next release of the DisCo agent should enable the secret sending by default, as we'd planned.