Skip to content

RTECO-1986 - Add e2e tests for --path auto-create - #3680

Merged
udaykb2 merged 6 commits into
masterfrom
RTECO-1896-improve-path-flag-in-agent-namespace
Sep 1, 2026
Merged

RTECO-1986 - Add e2e tests for --path auto-create#3680
udaykb2 merged 6 commits into
masterfrom
RTECO-1896-improve-path-flag-in-agent-namespace

Conversation

@udaykb2

@udaykb2 udaykb2 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

agent_plugins_test.go: TestAgentPluginsInstallCreatesMissingPath installs a plugin into a multi-level nonexistent --path and asserts it gets created and the plugin lands correctly.

agent_skills_test.go: add a path-install-creates-missing-dir subtest to TestAgentSkillsInstallPathAndFlags covering the same scenario for skills, matching that test's existing grouped-subtest convention.

Exercises the jfrog-cli-artifactory fix where --path now creates the target directory instead of erroring when it doesn't exist.

  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • The pull request is targeting the master branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....

agent_plugins_test.go: TestAgentPluginsInstallCreatesMissingPath installs
a plugin into a multi-level nonexistent --path and asserts it gets
created and the plugin lands correctly.

agent_skills_test.go: add a path-install-creates-missing-dir subtest to
TestAgentSkillsInstallPathAndFlags covering the same scenario for skills,
matching that test's existing grouped-subtest convention.

Exercises the jfrog-cli-artifactory fix where --path now creates the
target directory instead of erroring when it doesn't exist.
@udaykb2
udaykb2 marked this pull request as ready for review August 25, 2026 09:53
@udaykb2
udaykb2 force-pushed the RTECO-1896-improve-path-flag-in-agent-namespace branch from b613894 to a5bf9c2 Compare August 28, 2026 06:43
@udaykb2
udaykb2 deployed to build-gate August 28, 2026 06:44 — with GitHub Actions Active
@udaykb2
udaykb2 force-pushed the RTECO-1896-improve-path-flag-in-agent-namespace branch from 2ca6bf3 to 68d952d Compare September 1, 2026 13:45
@udaykb2
udaykb2 deployed to build-gate September 1, 2026 13:46 — with GitHub Actions Active
@udaykb2 udaykb2 added the safe to test Approve running integration tests on a pull request label Sep 1, 2026
@udaykb2
udaykb2 deployed to build-gate September 1, 2026 14:28 — with GitHub Actions Active
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

@udaykb2
udaykb2 merged commit e0df8a5 into master Sep 1, 2026
371 of 374 checks passed
@udaykb2
udaykb2 deleted the RTECO-1896-improve-path-flag-in-agent-namespace branch September 1, 2026 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Approve running integration tests on a pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants