Retry GetBuildInfo to absorb Artifactory index propagation lag - #3682
Merged
Conversation
fluxxBot
approved these changes
Aug 28, 2026
pm-version-monitor's pnpm compatibility runs showed a sharp,
date-correlated pass-rate collapse (100% -> ~25%) on days with heavy
concurrent CI load, spread across every pnpm line including the
officially-supported 10.x baseline -- not correlated with pnpm version
at all. Root cause traced to every failure sharing the same signature:
Error: Should be true
Messages: Build info was not found
tests.GetBuildInfo queried Artifactory immediately after
artifactoryCli.Exec("bp", ...) reported success, with no retry.
BuildInfoService.GetBuildInfo's own doc comment says a 404 surfaces as
(found=false, err=nil) -- exactly the shape of a build that was
published but whose search index entry hasn't propagated yet, which
happens more often under concurrent load hitting the same instance.
Add a short bounded retry (4 attempts, 500ms exponential backoff,
~7.5s worst case) inside GetBuildInfo itself so every one of its ~20
call sites across pnpm_test.go, npm_test.go, maven_test.go, etc.
benefits without individual changes. Only the found=false/err=nil
case retries; any real error still returns immediately, unchanged
from before.
agrasth
force-pushed
the
fix/pnpm-test-buildinfo-race
branch
from
September 1, 2026 09:13
6e10efb to
3af0959
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Error: Should be true/Messages: Build info was not found, immediately after a successfuljfrog rt bppublish.tests.GetBuildInfoqueried Artifactory right after the publish call returned success, with no retry.BuildInfoService.GetBuildInfo's own doc comment confirms a 404 surfaces as(found=false, err=nil)— exactly the shape of "published, but the search index hasn't caught up yet," which gets more likely the more concurrent CI load hits the same Artifactory instance.GetBuildInfoitself, so all ~20 call sites acrosspnpm_test.go,npm_test.go,maven_test.go, etc. benefit without touching each one individually. Only thefound=false, err=nilcase retries — any real error still returns immediately, unchanged from today's behavior.Test plan
go build ./...— succeedsgo vet ./utils/tests/...— cleanBuildInfoService.GetBuildInfo's doc comment in jfrog-client-go thatfound=false, err=nilis the documented 404 signal, so retrying only that case is safe and won't mask real failures