Commit Gitlab file size limit

[jbperrin88]

Preflight Checklist

• I agree to follow the Code of Conduct that this project adheres to.
• I have searched the issue tracker for a feature request that matches the one I want to file, without success.

Describe the bug
Make a big diagram and save it to gitlab
In this diagram i've a lot of shape with base64 image

To Reproduce
Steps to reproduce the behavior:

1. Go to File
2. Click on Save
3. Click on Commit wirh a message
4. See error

Error saving file
Drawing is too large (985.7 kB / 1 MB)

Expected behavior
No limit in size for this kind of save.

Screenshots

draw.io version (In the Help->About menu of the draw.io editor):

• draw.io version [e.g. 12.8.5] (SELF-HOSTED docker)

Desktop:

• OS: windows
• Browser : firefox
• Version : 73.0.1

Additional context
Add any other context about the problem here.

[jbperrin88]

OK ... SO i've succesfully change this limitation

This limitation comes from GitLabClient.js line 561
-> if (data.length >= this.maxFileSize)

But from my point of wiew there is no reason for this .

The variable maxFileSize is an extend from GitHubClient.js

I haven't seen any where this kind of limitation in both Git .

Best Regards

[lamoquette]

Hey @jbperrin88 ,

I was looking for a solution and I found your post.
Actually I did it through my DockerFile to apply the edit, but it doesn't seem to work, and still display the error when I try to commit the diagramm on gitlab.

I tried the followed Dockerfile, could you have a look ?

FROM jgraph/drawio:12.9.6-alpine

LABEL name="drawio-image"

# Give writable permission
RUN chmod a+rwx $CATALINA_HOME/webapps/draw

# Copy modified files to deactivate cloud storage and git size limitation
COPY PreConfig.js $CATALINA_HOME/webapps/draw/js/PreConfig.js
COPY GitHubClient.js $CATALINA_HOME/webapps/draw/js/diagramly/GitHubClient.js

WORKDIR $CATALINA_HOME

EXPOSE 8080 8443

ENTRYPOINT ["/docker-entrypoint.sh"]
CMD ["catalina.sh", "run"]

HEALTHCHECK NONE
USER 1001

In my GitHubClient.js :

GitHubClient.prototype.maxFileSize = 10000000 /*10MB*/;

in a nutshell :

Copy my own PreConfig.js though the dockerfile works
But not the GitHubClient.js

[quintesNZ]

Hello

Happened for me today as well,
Drawing is too large (1016 kB / 1 MB) was the error somewhere.

I've had to resort to device / local saves.

[DannyL9143]

I was able to hack a fix, but I think this should be investigated further. The reason why it does not work when you change GitLabClient.js is because the code overall is minified and needs to change app.min.js. So you either need to regenerate app.min.js after editing GitLabClient.js OR in my case I just edited app.min.js. I found the GitLabClient line to add it to, and then append it to the end of the line. My example is below.

The real fix should be perhaps to consider making maxFileSize configurable for each of the file modes or, as jbperrin88 pointed out, perhaps we do not need a maxFileSize variable for GitLab at all. In our case, we are managing the magnitude of the file size with Git LFS in our repository rather than needing Draw.io to manage it for us.

My example is on line 10026 of app.min.js for my particular version of this example (see the end of the line for my part to set maxFileSize):

GitLabFile.prototype.getMode=function(){return App.MODE_GITLAB};GitLabFile.prototype.getDescriptorEtag=function(a){return a.last_commit_id};GitLabFile.prototype.setDescriptorEtag=function(a,e){a.last_commit_id=e};GitLabLibrary=function(a,e,c){GitLabFile.call(this,a,e,c)};mxUtils.extend(GitLabLibrary,GitLabFile);GitLabLibrary.prototype.doSave=function(a,e,c){this.saveFile(a,!1,e,c)};GitLabLibrary.prototype.open=function(){};GitLabClient=function(a){GitHubClient.call(this,a,"gitlabauth")};mxUtils.extend(GitLabClient,GitHubClient);GitLabClient.prototype.clientId=DRAWIO_GITLAB_ID;GitLabClient.prototype.scope="api%20read_repository%20write_repository";GitLabClient.prototype.baseUrl=DRAWIO_GITLAB_URL+"/api/v4";GitLabClient.prototype.authToken="Bearer";GitLabClient.prototype.maxFileSize=1E8;

[davidjgraph]

Increased to 10MB for next build.

[davidjgraph]

Deployed in 13.6.0

[NebzHB]

Dear, possible to extend it for GitHubClient too ?

[davidjgraph]

Please file a new issue for new requests.

[indrex]

I am on v14.6 but I still see the same issue - 1 MB limit

[davidjgraph]

@indrex what URL are you using? That message is 10MB in the code since 13.6. Are you sure you are saving to Gitlab?

[indrex]

Sorry, my bad, I was committing to a GitHub repo not to GitLab :(

[luolixuan]

I use draw.io web interface, still have this problem when I try to commit to GitHub. Any suggestion? Thanks!

[davidjgraph]

Reduce the file size below 10MB.