docs: interpreter-aware injection guidance - #9
Merged
Conversation
mdtask already runs python/ruby/node fences, where there is no shell doing the
quoting, so the old "use $name, the shell quotes it" advice was sh-only. Restate
it correctly: raw {{ arg }} is unsafe in any language; the safe form is to read
the value from the environment ("$name" in a shell, os.environ["name"] in Python,
process.env.name in Node). Applies to the Args doc, the MCP module doc, the
agent-refusal message, and script_arg_templates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folds into unreleased 0.2.0. The injection-remediation advice ("use
$name, the shell quotes it") was sh-only, but mdtask already runs python/ruby/node fences. Restated: raw{{ arg }}is unsafe in any language; the safe form is read-from-environment ("$name",os.environ["name"], ...). Updates the Args doc, MCP module doc + refusal message, andscript_arg_templates. Doc/comment-only; gate green.🤖 Generated with Claude Code