Skip to content
This repository was archived by the owner on Nov 27, 2018. It is now read-only.

HTTPS security fixes: Use TLS instead of SSL v3; actually verify server certificate. #12

Merged
merged 2 commits into from
Nov 20, 2014
Merged

HTTPS security fixes: Use TLS instead of SSL v3; actually verify server certificate. #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
033193b
Tell CURL to use TLS instead of SSLv3.
cakoose Oct 28, 2014
9af6a9a
Tell cURL to verify the server's certificate.
cakoose Oct 28, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions libraries/Dropbox.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,9 +477,11 @@ private function _connect($url, $header, $request, $postdata = false, $destinati
{
$ch = curl_init($url);
curl_setopt($ch, CURLOPT_HTTPAUTH, CURLAUTH_BASIC ) ;
curl_setopt($ch, CURLOPT_SSLVERSION,3);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, FALSE);
curl_setopt($ch, CURLOPT_SSLVERSION, 1); // Require TLS
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, true);
curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, 2);
curl_setopt($ch, CURLOPT_CAINFO, __DIR__."/certs/trusted-certs.crt");
curl_setopt($ch, CURLOPT_CAPATH, __DIR__."/certs/");
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_CUSTOMREQUEST, $request);
curl_setopt($ch, CURLOPT_HTTPHEADER, explode(self::LINE_END, $header));
Expand Down
Loading