deps: bump github.com/charmbracelet/glamour from 0.7.0 to 0.10.0 by dependabot[bot] · Pull Request #2 · jingle2008/toolkit

dependabot · 2025-06-07T05:10:42Z

Bumps github.com/charmbracelet/glamour from 0.7.0 to 0.10.0.

Release notes

Sourced from github.com/charmbracelet/glamour's releases.

v0.10.0

Actually readable tables

Big tables that included links were always hard to read. Links can be very long, and tables often have limited space to render them. This means that links often took the space of many lines and weren't properly clickable because they were being truncated in practice.

Starting on this release, Glamour will render links and images at the footer of the table, with a reference number so you can easily find the link you're looking for. If you want the old behavior, it is still supported via the new WithInlineTableLinks option.

The New Way

The Old Way

Wanna render tables with inline links? You still can:
r, err := glamour.NewTermRenderer(glamour.WithInlineTableLinks(true))
if err != nil { /*...*/ }
out, err := r.RenderBytes(in)
if err != nil { /.../ }
fmt.Fprintf(os.Stdout, "%s\n", out)
Prettier GitHub links

We also introduced a change so that GitHub links inside tables that reference issues, discussions or PRs will be shown in its shortened form, similar to how GitHub itself present the links on issue descriptions: owner/repo#123.

Extra

Also, we introduced WithTableWrap, so you can disable table text wrapping if really want:
r, err := glamour.NewTermRenderer(glamour.WithTableWrap(false))
if err != nil { ... }
out, err := r.RenderBytes(in)
if err != nil { ... }
fmt.Fprintf(os.Stdout, "%s\n", out)
Changelog

New Features

... (truncated)

Commits

05ee9b5 v0.10.0
c9af045 feat(tables): format github links inside tables in a more readable manner
f2eb484 feat: add autolink package with patterns for more readable github urls
9d87373 feat(table): pad position on table link list
a11e9a0 feat(table): show position of link also inside the table
42f47a2 feat(table): prefix all links with the position in the footer
61cfc45 feat(table): add ability to render links at the bottom
5437e4a fix: ensure that prop is always cleared
60534f9 chore(deps): bump golang.org/x/term from 0.30.0 to 0.31.0 (#418)
606f55a chore(deps): bump golang.org/x/text from 0.23.0 to 0.24.0 (#419)
Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

dependabot · 2025-06-07T05:10:42Z

Labels

The following labels could not be found: automerge, dependencies. Please create them before Dependabot can add them to a pull request.

Please fix the above issues or remove invalid values from dependabot.yml.

Bumps [github.com/charmbracelet/glamour](https://github.com/charmbracelet/glamour) from 0.7.0 to 0.10.0. - [Release notes](https://github.com/charmbracelet/glamour/releases) - [Changelog](https://github.com/charmbracelet/glamour/blob/master/.goreleaser.yml) - [Commits](charmbracelet/glamour@v0.7.0...v0.10.0) --- updated-dependencies: - dependency-name: github.com/charmbracelet/glamour dependency-version: 0.10.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

Code-review feedback #2: LoadGpuPools returned (pools, nil) when one of its three HCL sources failed but others succeeded. Callers had no signal that the result was incomplete — the TUI rendered the partial table, and the headless `toolkit get` produced silent-partial JSON. Introduce terraform.PartialLoadError with Source + per-source Errs (Unwrap returns []error for errors.Is/As walks). LoadGpuPools now: - all succeed: (pools, nil) - mixed: (pools, *PartialLoadError) - all fail: (nil, fmt.Errorf("failed to parse HCL file: …")) TUI loader_cmd.loadGpuPoolsCmd detects via errors.As and treats it as non-fatal (current behavior preserved; the partial-failure note goes to the existing log file). CLI get.go GpuPool case detects via errors.As and prints warning: GpuPools: N source(s) failed to load: … to stderr, then continues with the partial slice. Scripts and LLM consumers now see explicitly that results are incomplete instead of silently trusting a half-empty table. Adds TestLoadGpuPools_PartialFailure exercising the new contract (two valid HCL sources + one with the wrong local name). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

#1 (go.mod/go.sum): `go mod tidy` moved github.com/modelcontextprotocol/go-sdk out of the //indirect block. It's a direct import from internal/mcp/server.go. #2 (internal/mcp/server.go:Run): document blocking semantics, EOF / ctx-cancel exit conditions, and the single-shot constraint (a second Run on the same Server reuses the SDK's session list). #3 (internal/cli): extract validateLoaderConfig out of validateGetConfig so runMCP shares the four-field env check. Both surfaces now report "missing required setting(s): ..." with consistent wording. Kept the kubeconfig stat in validateGetConfig — only get needs it. #4 (internal/cli/output/output.go): document FlattenWithKey's collision rule. If T's JSON encoding contains a field named groupField, the map key wins and the original value is silently overwritten. Currently safe (pool/tenant/model don't collide with any pkg/models tag), but locked in writing for future-proofing. #5 (internal/cli/output/output_test.go): add direct tests for FlattenWithKey covering nil/empty maps, single entry, sort stability across multiple groups, omitempty respected, and the collision-overwrite contract from #4. Outstanding from the latest review: an in-memory MCP integration test for the JSON-RPC framing path (#6). Coming next in a separate commit. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Addresses the second round of review feedback. Important #1 — env_override is now an explicit opt-in: - New config field MutationEnvOverrideAllowed (default false) with matching --mutation_env_override_allowed persistent flag. - effectiveMutationEnv applies the agent's envOverride only when the operator opted in; otherwise the override is silently dropped AND audit-logged at info, preserving "operator's startup-env choice caps blast radius" as the safety story. - When the override IS applied AND deviates from startup, an info-level "level=warn" audit line records the deviation for SIEM visibility. - Tool descriptions now honestly describe the trade-off via a central mutationToolFooter constant. The previous "parity with list_*" framing understated the security cost; the new shape keeps the parity benefit (multi-realm operators can opt in) without the silent capability expansion. Important #2 — failed-phase event name unified: - Both CLI mutate.go and MCP mutations.go now emit Errorw with event="mutation", phase="failed". Aggregators filtering on a single `phase` discriminator now capture all four states (begin / done / failed / refused). Important #3 — env_override propagation coverage: - TestIntegration_MutationTool_IgnoresEnvOverride_WhenDisallowed: default config drops the agent's env_realm/env_region. - TestIntegration_MutationTool_HonorsEnvOverride_WhenAllowed: flag-set config honors override (renamed from prior test). - TestIntegration_MutationTool_PropagatesEnvOverride: reboot/terminate/scale all assert env reaches BOTH the resolver seam and the action seam — the hops where a future refactor could accidentally drop the override. Minors: - #4: gofmt double blank line in mutate.go (mutations_test.go and tools.go also picked up trailing-whitespace fixes from the same pass). - #5: mutationToolFooter centralizes the env-override clause so drift across the seven descriptions is not possible. - #7: drop the resolveNodeForOCIAction / resolveGpuPoolForOCIAction methods — they were pure passthroughs after the prior commit. The handlers now call mcpResolveGpuNodeFn / mcpResolveGpuPoolFn directly. newTestPair now accepts a variadic config-mutator option so tests that need to flip the flag don't have to fork the helper. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Addresses the Important items from the post-refactor code review: - list_handlers_test.go: factor TestList_GpuNodes_TypedWrapperShape into a shared assertGroupedWrapperShape helper; add equivalent TestList_DACs_TypedWrapperShape and TestList_ModelArtifacts_ TypedWrapperShape so all three grouped wrappers carry regression bait. (The helper avoids the dupl-detector complaint that three near-identical tests would trigger.) - list_handlers_test.go: add TestGroupedWrapper_NoDuplicateGroupKey sentinel — marshals each of the three wrappers and asserts the group-key JSON field appears exactly once. Fails loudly the day any underlying model gains a clashing `pool`/`tenant`/`model` JSON tag. - mutations_test.go: TestIntegration_MutationTool_ConfirmTrueExecutes now asserts StructuredContent carries the mutationResult shape directly (status/action/kind/target), and explicitly checks the absence of list-envelope keys (items/count). Closes the gap where a future refactor accidentally routing mutations back through jsonResult would have passed the TextContent-only assertion. - .goreleaser.yaml: fix stale comment ("four env vars" -> "five") on the notarize gate — the actual isEnvSet expression checks five secrets and the docs say five; the comment was the only outlier. - CONTRIBUTING.md: add a "Release infrastructure (maintainer-only)" section noting that macOS notarization depends on an active $99/yr Apple Developer Program enrollment, and that the Homebrew tap PAT needs Contents:write on both repos. Surfaces the recurring-cost + token-rotation reality for future maintainers. Skipping (post-merge follow-up): the half-configured-notarize loud-fail gate (Important #2). Cheap to add later before the first real notarized release; the verification step in the docs is the short-term mitigation. Verified: go test ./..., make fmt-check, make goimports-check, golangci-lint run ./... all green. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Three Important + three Minor follow-ups from the post-commit review: Important #1 — MCP integration test for enrichment failure: - New TestIntegration_NotifiesOnGpuPoolEnrichmentFailure (and a tiny fixedGpuPoolsLoader helper) drives list_gpu_pools against a non-empty stub loader with KubeConfig pointed at a missing file. Asserts: tool call succeeds (IsError=false), Terraform-derived pool still rendered with placeholder status, enrichment warning appears in BOTH the StructuredContent.warnings envelope AND as a notifications/message frame. Was a real coverage gap — previous partial-load integration test returned nil pools, taking EnrichGpuPools's empty-slice fast-path. Important #2 — GpuPool JSON shape pin-test: - New TestWriteSlice_GpuPool_JSONShape asserts every key on the rendered object uses the lowercase JSON tags introduced in v0.3.0 (name / shape / actualSize / status / capacityType / …) and that no capitalized struct-field name leaks. The CHANGELOG claimed shape-unchanged; this test backs that claim. Important #3 — Structured log for enrichment failures: - EnrichGpuPools now emits a logger.Infow line at each failure point with `step=compartment_id|populate` plus the error, matching the Infow pattern resolve.GpuPool already uses for partial-load. Long-running MCP servers degrade visibly in logs instead of only via tool output. Logger interface has no Warnw — using Infow stays consistent with the existing partial-load log shape. Minor #4 — CHANGELOG calls out the NONEXIST status: - A Terraform-defined pool that hasn't been applied yet now shows `status: "NONEXIST"` after enrichment (the literal value PopulateGpuPools writes when OCI returns 200 but excludes the pool from its result). Same as TUI behavior; just wasn't documented for CLI/MCP consumers. Minor #7 — CHANGELOG calls out the offline-experience change: - `toolkit get gpupool` was previously offline-capable; one K8s lookup attempt is now made before any output renders. Added a sentence explaining the new latency on no-auth hosts. Minor #8 — CLI warning prefix symmetry: - Partial-Terraform failures previously printed `warning: <err>`; enrichment failures print `warning: gpu pool enrichment incomplete: <err>`. Both are now prefixed by their step (`warning: load gpu pools: ...` vs `warning: gpu pool enrichment incomplete: ...`) so a reader can tell at a glance which one fired. Skipped from the review's Minor list: - #5 (string→error return type for EnrichGpuPools) — pure style call, current shape reads cleanly at both call sites; defer to a future pass if/when call sites grow. - #6 (categorized warnings field) — would require restructuring the warnings array into typed entries (Terraform vs enrichment). Bigger surface change than this review warrants. Verified: go test ./..., make fmt-check, make goimports-check, golangci-lint run ./... all green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Code-review follow-up to the four-commit ImportedModel feature (02fdba7 .. 2c1090e). All review feedback addressed: Important #1 — MCP description claimed a `source` field that was dropped in 0d194ae. Replaced with the orthogonality guidance the Go doc and CHANGELOG now use. Agents planning JSON paths against the tool description will no longer be misled. Important #2 — CHANGELOG was missing the silent BaseModel filter change (02fdba7). Added a `### Changed` entry explicit about the count delta — `toolkit get basemodel -o json | jq length` returns fewer items on clusters with tenant-scoped CBMs. Points readers at the new `importedmodel` category to recover the full set. Important #3 — Confirmed via inventory of pkg/models that ImportedModel is the only category with both Namespace and TenantID (DAC, LimitTenancyOverride, ConsolePropertyTenancyOverride each have TenantID alone). Adopting the DAC pattern: TenantID is the OCI tenant identifier (from `tenancy-id` label, populated on any source that carries the label); Namespace is the K8s scope (the authoritative source-kind indicator). They're orthogonal facets, not synonyms. Loader behavior unchanged — only documentation flips, in three places: - pkg/models/imported_model.go: expanded doc-comment with the "orthogonal facets" framing and explicit consumer guidance ("which K8s scope" vs "which OCI tenant"). - internal/mcp/tools.go (list_imported_models description): same clarification, replacing the stale `source` mention. - CHANGELOG: same framing, with the DAC-pattern reference. Important #4 — Added a deliberate comment in LoadImportedModels explaining the all-or-nothing semantics vs. the LoadGpuPools partial-error idiom. The two sources here are conceptually one catalog; a half-loaded result is more confusing than an explicit error, and the cross-GVR RBAC asymmetry (namespaced `basemodels` vs cluster-scoped `clusterbasemodels`) is the realistic failure mode the comment calls out. Minor #5 — TestList_ImportedModels_FlatShape doc-comment said the test asserts `source` is present; corrected to reflect that the test now asserts `source` is absent (the post-0d194ae contract). Skipped from the review's Minor list: - #6 (lint suppression placement) — pre-existing, no change. - #7 (split routeLoadingDataMsg following the routeList* pattern) — could land in a follow-up if the next addition pushes the message count above the cyclop ceiling again; not urgent at 10. - #8 (ResetScopedData consistency) — already correct. - #9 (StorageURI placement on BaseModel vs ImportedModel) — already the right call, no change. - #10 (CLI table readability) — passed review. Verified: go test ./..., make fmt-check, make goimports-check, golangci-lint run ./... all green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Review follow-ups for 74723fd: Important #1 — Harmonize the orphan-tenant sentinel across DAC and ImportedModel. DAC's V1/V2 extractors previously branched on hasLabels and defaulted to the literal "missing" — different from the "UNKNOWN_TENANCY" sentinel ImportedModel and tenantIDFromLabels already use for the labels-present-but-no-tenancy-id case. tenantIDFromLabels(nil) already returns "UNKNOWN_TENANCY", so calling it unconditionally collapses the two sentinels into one and matches the policy the user picked ("same convention as DAC"). The dead-`hasLabels` variables are tagged with `_ = hasLabels` to keep the surrounding signatures unchanged. As a follow-on, the now-redundant tenantIDFromUnstructured wrapper in imported_model.go is inlined — its only purpose was to bridge the "labels absent" case, which tenantIDFromLabels(labels) handles identically. One less abstraction, one less typo surface. Important #2 — TestSetImportedModelMap added, mirroring TestSetDedicatedAIClusterMap line-for-line. Covers both the matched-by-suffix path (re-keys to Tenant.Name, sets Owner pointer) and the unmatched path (key passes through, Owner stays nil). A small generic `keys[V any]` helper feeds the diagnostic Errorf message. Important #3 — TestResetScopedData now seeds ImportedModelMap and asserts it's nil after Reset. Production code (dataset.go:78) already resets it; this test pins the contract so a future drop of the reset line fails fast. Important #4 — CHANGELOG TUI column claim corrected to the shipped order: Name, Tenant, Namespace, Display Name, Version, DAC Shape, Flags, Status. The previous text described an in-development layout that didn't match the final headers.go definition. Also added a sentence on the CLI/TUI tenant-column asymmetry (CLI shows raw OCID, TUI shows resolved Tenant.Name via SetImportedModelMap) — same as DAC's behavior, but never documented before. Skipped from the review's Minor list (filed for follow-up): - #5 (UNKNOWN_TENANCY as a `const`): three sites now share the same literal via tenantIDFromLabels; extracting a const is a micro-cleanup that's strictly post-release. - #7 (suffix-match bug in SetXxxMap): pre-existing in DAC, not introduced by this work — separate fix. Verified: go test ./..., make fmt-check, make goimports-check, golangci-lint run ./... all green. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

…save Resolves seven review findings across the TUI/CLI/config layers; each fix is covered by a test that fails before the change. - DAC delete (dac_actions.go): guard nil OpcRequestId in the delete error path via a new derefOr helper, and reject a nil work-request id in waitForWorkRequest instead of dereferencing/polling it; skip endpoint summaries with a nil DedicatedAiClusterId rather than panicking the whole deletion. [findings #2, #3] - GPU pool enrichment (gpu_node_actions.go): skip instance-pool summaries missing DisplayName/Id/Size (extracted applyInstancePoolSummaries) so a partial OCI response can't crash get/list/scale. [finding #5] - Lazy loading (model.go): add GPUWorkload to lazyLoadedCategories so `toolkit -c gpuworkload` issues the category load on direct startup. A contract test now asserts every kube-backed category is lazy-loaded. [finding #4] - DAC delete timeout (model_state.go, update_list_ops.go): run the multi-minute deletion under a new uncapped longOpCtx instead of the 30s opCtx, so its own internal timeout governs. [finding #6] - Atomic metadata save (metadata_save.go): writeFileAtomic writes a temp file, fsyncs, then renames, so an interrupted write can't corrupt the existing file. [finding #8] - stderr sink (redirect_stderr_unix.go): 0644 -> 0600 to keep captured auth-plugin output and panic stacks private. [finding #7] Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Fixes the half-migrated lint config and the tool-version drift between the Makefile and go.mod (review findings #1 and #2). .golangci.yml was `version: 2` but retained v1-only sections (`linters-settings`, `presets`, `severity`, `issues.exclude-use-default`). `golangci-lint config verify` rejected it, and `run` silently ignored the `linters-settings` block — so authored tuning was inert (e.g. cyclop ran at the default max 10 instead of the configured 13). - Migrate to the v2 schema: `version: "2"`, move settings under `linters.settings`, drop the v1-only sections. Net behavior change is the intended one — cyclop now applies its configured max of 13 (a relaxation). `presets`/`severity`/`exclude-use-default` and the contextcheck/revive keys were already inert under v2, so dropping them is behavior-neutral. - Add `golangci-lint config verify` to `make lint` so the config can't silently rot out of schema again. - Unify Makefile `setup` tool versions with the go.mod pins (golangci-lint v2.12.2, gofumpt v0.10.0, goimports/x-tools v0.46.0) via named variables documented as the single source of truth. Verified locally with golangci-lint v2.3.1: `config verify` passes and `golangci-lint run ./...` reports 0 issues. The bump of the installed golangci-lint to v2.12.2 (the version go.mod already pins) is validated by CI. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Migrate golangci-lint config to v2 schema and unify dev-tool versions with go.mod pins (review findings #1, #2). config verify now passes and the authored linter settings (e.g. cyclop max 13) actually apply. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

dependabot Bot force-pushed the dependabot/go_modules/github.com/charmbracelet/glamour-0.10.0 branch 2 times, most recently from 7ee303f to 01aa56a Compare June 11, 2025 06:35

dependabot Bot force-pushed the dependabot/go_modules/github.com/charmbracelet/glamour-0.10.0 branch from 01aa56a to bf83cb8 Compare June 15, 2025 16:37

jingle2008 merged commit 082946f into main Jun 15, 2025

dependabot Bot deleted the dependabot/go_modules/github.com/charmbracelet/glamour-0.10.0 branch June 15, 2025 18:06

Navigation Menu

deps: bump github.com/charmbracelet/glamour from 0.7.0 to 0.10.0 - #2

deps: bump github.com/charmbracelet/glamour from 0.7.0 to 0.10.0#2
jingle2008 merged 1 commit into
mainfrom
dependabot/go_modules/github.com/charmbracelet/glamour-0.10.0

dependabot Bot commented on behalf of github Jun 7, 2025 •

edited

Loading

Uh oh!

dependabot Bot commented on behalf of github Jun 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

dependabot Bot commented on behalf of github Jun 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

v0.10.0

Actually readable tables

The New Way

The Old Way

Prettier GitHub links

Extra

Changelog

New Features

Uh oh!

dependabot Bot commented on behalf of github Jun 7, 2025

Labels

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

dependabot Bot commented on behalf of github Jun 7, 2025 •

edited

Loading