Skip to content

fix(memory): pass CCC_PIRI_REAL_CLI_PATH through the distill extractor environment - #978

Merged
jinon86 merged 1 commit into
mainfrom
fix/piri-distill-real-cli-passthrough
Aug 6, 2026
Merged

fix(memory): pass CCC_PIRI_REAL_CLI_PATH through the distill extractor environment#978
jinon86 merged 1 commit into
mainfrom
fix/piri-distill-real-cli-passthrough

Conversation

@jinon86

@jinon86 jinon86 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

문제

RuntimeCliDistillBackend의 최소 환경 화이트리스트(_PIRI_ENV_NAMES)가 CCC_PIRI_REAL_CLI_PATH를 떨어뜨립니다. CCC_PIRI_CLI_PATH가 ccc-piri 래퍼를 가리키는 노드에서 추출기가 래퍼를 호출하면, 래퍼는 real CLI를 이 변수로만 해석하는데 변수가 없어 bare piri PATH 검색으로 폴백 → fleet 노드의 기본 PATH에는 piri가 없어 **모든 추출이 exit 127(distill_nonzero_exit)**로 실패합니다.

실측(2026-08-06, dungae): #974 배포 후 스냅샷은 성공하지만 추출 단계에서 3/3 provider_exit_status=127. 최소 환경 재현으로 확인.

수정

  • _PIRI_ENV_NAMESCCC_PIRI_REAL_CLI_PATH 추가 (값 passthrough만, 신규 시크릿 아님 — 실행 경로)
  • 회귀 테스트 추가

검증

  • pytest 대상 파일 12 passed, ruff/mypy clean, format diff는 베이스라인과 동일
  • dungae 수동 재현: 최소 env + CCC_PIRI_REAL_CLI_PATH 설정 시 래퍼 경유 추출 정상(ec=0)

@jinon86
jinon86 requested a review from seoseo-ai as a code owner August 6, 2026 02:34

@seoseo-ai seoseo-ai left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after explicit operator authorization using the local seoseo-ai credential.

…r environment

The Piri extraction backend builds a minimal environment; dropping
CCC_PIRI_REAL_CLI_PATH left ccc-piri wrapper launches without a real CLI
(bare 'piri' is not on the default PATH on fleet nodes), failing every
extraction with exit 127 (distill_nonzero_exit, retryable).
@jinon86
jinon86 force-pushed the fix/piri-distill-real-cli-passthrough branch from 4983e77 to c30dbda Compare August 6, 2026 02:42
@jinon86
jinon86 merged commit 0aac25b into main Aug 6, 2026
8 checks passed
@jinon86
jinon86 deleted the fix/piri-distill-real-cli-passthrough branch August 6, 2026 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants