Skip to content
This repository was archived by the owner on Oct 11, 2018. It is now read-only.

Conversation

@westonruter
Copy link

This copies the approach used to install Composer via phar.

Will fix https://github.com/Automattic/vip-quickstart/issues/289

@jippi
Copy link
Owner

jippi commented Feb 10, 2015

seems legit 👍

@igalic
Copy link
Collaborator

igalic commented Feb 10, 2015

proposal: replace exec-wget, with @maestrodev's wget.
(here, and in composer)

@jippi
Copy link
Owner

jippi commented Feb 10, 2015

won't that make it pain in the ass for people to install dependencies ?

@joshbetz
Copy link
Contributor

An external dependency to make wget easier seems like overkill. @jippi is there anything else that needs to happen before this is merged?

@jippi
Copy link
Owner

jippi commented Feb 13, 2015

Other than the ensure should be absent = delete the file again I think its good

@westonruter
Copy link
Author

I confess I am not a puppet master. Where would "absent = delete" go?

@jippi
Copy link
Owner

jippi commented Feb 14, 2015

ensure = absent should be in the primary manifest, and just delete the composer file :)

@westonruter
Copy link
Author

Like b6e83bd?

@joshbetz
Copy link
Contributor

Probably something like:

if ( 'absent' == $ensure ) {
  file { $destination:
    path   => $destination,
    ensure => absent
  }
} else {
  // Install phpunit
}

@westonruter
Copy link
Author

@joshbetz I'm out of my depth here. I'll leave it with you.

@joshbetz
Copy link
Contributor

Thanks @westonruter. It looks like schkovich@ea1ead5 breaks Quickstart too so hopefully we can get that reverted. Otherwise I'll look into a workaround.

@igalic
Copy link
Collaborator

igalic commented Feb 17, 2015

i believe this is now covered by #128
thank you @joshbetz and @westonruter!

@igalic igalic closed this Feb 17, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants