This repository was archived by the owner on Oct 11, 2018. It is now read-only.
Install PHPUnit via Phar #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@joshbetz i still think that @maestrodev's wget is a good thing to have, because unllike your exec, their exec actuall handles all edge-cases. to quote Green's 10th Rule of Programming
;) in puppet we have modules, and using them is as simple as adding a line into a file, so i think we should. that said, we can leave it for another time, with a specific pr covering the conversion. |
Owner
|
👍 |
Collaborator
|
we should also make a mental now to extract the |
Collaborator
|
thank you @joshbetz |
Owner
|
👏 |
schkovich
added a commit
to schkovich/puppet-php
that referenced
this pull request
Feb 27, 2015
…PUnit phar archive instead of deprecated PEAR method. However corresponding parameters class was not updated causing following error: ``` Error: Parameter path failed on File[undef]: File paths must be fully qualified, not 'undef' at /home/vagrant/opt/puppet/modules/php/manifests/phpunit.pp:55 ``` Updated php::phpunit::params class and added basic tests. refs jippi#128 refs jippi#104
Merged
cegeka-jenkins
pushed a commit
to cegeka/puppet-php
that referenced
this pull request
Mar 21, 2018
Enable extension when package already installed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #124