Idea: Redirect console warnings

[crishoj]

ads-client has the option hideConsoleWarnings to suppress console warnings.

For applications with centralized logging, it could be useful to "catch" these warnings from ads-client rather than suppressing them.

Perhaps an option for a custom console logging function:

{
  consoleLogger?: (message?: any, ...optionalParams: any[]) => void
}

It could default to console.log.

[jisotalo]

Actually I just thinking when I was writing the documentation that there should be a console event. So it would be possible to catch all console output using client.on('console', handleConsole) or similar.

What do you think?

[crishoj]

A console event would be perfect!

[crishoj]

Proposal (with event name warning): #152

[jisotalo]

@crishoj

Probably related to #150 as well.

Should we change this unknown notification client-error to a warning event instead? That would suit the case better.

ads-client/src/ads-client.ts

Line 1833 in ed8826a

this.emit('client-error', new ClientError(`onAdsCommandReceived(): Notification received with unknown handle ${sample.notificationHandle} (${key}). Use unsubscribe() to save resources.`));

[jisotalo]

Actually, it should be a warn() call instead? That would make more sense.

[crishoj]

Agreed, that makes sense

[crishoj]

Probably related to #150 as well.

I could include the proposed optional automatic deletion of stale notification handles in PR #152, or do a separate PR with that.

[jisotalo]

Thanks! A separate PR sounds good