Fix span of IOperation nodes#151
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves source-span mapping in the compiler tree formatter by adding explicit span handling for Roslyn IOperation nodes, and updates the local eng/build.sh workflow to use dotnetup instead of the older dotnet-install.sh flow.
Changes:
- Map
IOperationobjects tooperation.Syntax.SpaninTreeFormatter.getSpan(...)to improve source mapping for operation nodes. - Switch
eng/build.shfrom downloading/runningdotnet-install.shinto a local./dotnetfolder to installing viadotnetupand usingdotnetfrom PATH.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Compiler/TreeFormatter.cs | Adds span resolution for IOperation nodes to improve mapping behavior. |
| eng/build.sh | Replaces local dotnet-install.sh bootstrap with dotnetup-based SDK setup and uses dotnet directly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.