feat(integrations): re-discover knowledge and audit orphans at review - #86
Merged
Conversation
The review gate trusted the plan's original knowledge cover and let artifacts outlive the behavior they described. Recompute discovery against the final tree before assigning a verdict, so a contract found late expands the gating cover, and audit retained comments, tests, docs, config, fixtures, telemetry, and generated files for a surviving subject or consumer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two requirements to the developer review stage in the
tapper-devskill workflow, sourced frompkg/integrations/renderdata/developer/workflow.mdand rendered into both the Claude and Codex plugin skills.1. Recompute knowledge discovery before assigning a verdict. Review previously trusted the plan's original cover. Now discovery is recomputed against the final tree, starting from the touched KEG subjects and the vocabulary and behavior the diff changed, via targeted
backlinks/links/grepcalls in the active flight's covered KEGs. Informative knowledge guides interpretation; only applicable active or stale interfaces and verifications enter the gating cover. A contract discovered late expands the cover and sends the work back through any newly required gates.2. Audit artifacts that outlived their subject. Every retained comment, test, document, config value, fixture, telemetry hook, and generated artifact referring to removed, deprecated, or legacy behavior needs a surviving subject or consumer — current observable behavior, an accepted decision, a compatibility or migration boundary, a security or protocol prohibition, or an active invariant. If its only owner is the removal itself, it is orphaned noise and the work is returned. Artifacts are rewritten around the broader surviving invariant when that is the real contract, and are not rejected merely for using the word
legacy.The guidance is deliberately keg-agnostic — it names the active flight's covered KEGs rather than any specific one.
Changes
pkg/integrations/renderdata/developer/workflow.mdintegrations/rendered/{claude,codex}/tapper-dev/skills/tapper-dev/SKILL.mdtask render-integrationspkg/integrations/adapters/{claude,codex}_test.goTesting
go build ./...go test ./pkg/integrations/...— passingtask render-integrationsis clean: re-rendering reproduces the committedSKILL.mdbyte-for-byte (the only re-render delta was theplugin.jsonversion stamp, which the release pipeline owns, so it is not included here)