feat: integrate mixed-source regular playlists - #142
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements end-to-end support for mixed-source regular playlists (PR #142), allowing users to combine local tracks with entries from authenticated Subsonic, Jellyfin, Plex, and DAAP catalogues. Key changes include atomic all-or-none additions, exact removal of duplicate or unavailable entries using durable occurrence IDs, and a robust projection layer that renders explicit localized unavailable rows for disconnected sources or missing tracks. Additionally, the playback queue now tracks per-row media ownership and revalidates transient closed guards at the point of use for remote stream and artwork resolution. Rating writes and playback history remain restricted to local tracks. There are no review comments provided, so I have no feedback to evaluate.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 625d352888
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
Review follow-up
manual_option_zipcompatibility.Validation
cargo test --release: 1,144 passedcargo +1.92 check --all-targets --lockedcargo clippy --all-targets --all-features -- -D warningscargo clippy --release -- -D warningscargo build --release --all-featurescargo fmt --all -- --checkgit diff --checkImplements the mixed-source regular-playlist portion of #47. Import and pull synchronization of playlists owned by a Subsonic server remain a separate follow-up capability.