Fail closed when audio is missing or media is an LFS pointer - #162
Merged
Conversation
timing_sync and recording stream/drift/ocr/av_sync no longer skip-PASS on omitted mp3 or Git LFS pointer files. Co-authored-by: Cursor <cursoragent@cursor.com>
Ungenerated bundles stay pushable; LFS pointer and stale timing remain hard fails. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
timing_syncreturnspassed=Falsewhen audio is missing or an LFS pointer.stream_presence,av_drift,ocr_scan, andav_syncinstead of one skip-PASSlfs_pointercheck._check_timing_syncCCN 12 → 11). Did not bumpbenchmark_data/baseline.json.Test plan
test_omitted_audio_timing_sync_failstest_lfs_pointer_audio_timing_sync_failstest_lfs_pointer_recording_does_not_skip_passtest_no_audio_fails(replaces skip-PASS)ruff checkon changed filesMade with Cursor