Skip to content

Fail closed when audio is missing or media is an LFS pointer - #162

Merged
jmjava merged 2 commits into
mainfrom
cursor/missing-audio-lfs-fail-closed
Sep 11, 2026
Merged

Fail closed when audio is missing or media is an LFS pointer#162
jmjava merged 2 commits into
mainfrom
cursor/missing-audio-lfs-fail-closed

Conversation

@jmjava

@jmjava jmjava commented Sep 11, 2026

Copy link
Copy Markdown
Owner

Summary

  • Leftover Text() color must be keyword argument — positional arg causes cryptic ValueError #9: omitted mp3 and Git LFS pointer files no longer skip-PASS media gates.
  • timing_sync returns passed=False when audio is missing or an LFS pointer.
  • An LFS pointer recording fails stream_presence, av_drift, ocr_scan, and av_sync instead of one skip-PASS lfs_pointer check.
  • Helpers stay small so the PR-diff complexity gate does not rise (_check_timing_sync CCN 12 → 11). Did not bump benchmark_data/baseline.json.

Test plan

  • test_omitted_audio_timing_sync_fails
  • test_lfs_pointer_audio_timing_sync_fails
  • test_lfs_pointer_recording_does_not_skip_pass
  • test_no_audio_fails (replaces skip-PASS)
  • ruff check on changed files
  • CI lint / unit / benchmark / validate green

Made with Cursor

jmjava and others added 2 commits September 11, 2026 15:08
timing_sync and recording stream/drift/ocr/av_sync no longer skip-PASS on omitted mp3 or Git LFS pointer files.

Co-authored-by: Cursor <cursoragent@cursor.com>
Ungenerated bundles stay pushable; LFS pointer and stale timing remain hard fails.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jmjava
jmjava merged commit 9df895d into main Sep 11, 2026
7 checks passed
@jmjava
jmjava deleted the cursor/missing-audio-lfs-fail-closed branch September 11, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant