Fail closed when manim story_end and subject-beat have no scene spec - #163
Merged
Merged
Conversation
…subject-beat. Hand-authored scenes.py used to skip-PASS those checks; a paced manim film without *.scene.yaml now fails instead. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
story_endandsubject_beat_coverageno longer skip-PASS when*.scene.yamlis missing on atype: manimsegment (hand-authoredscenes.pyis not a free pass)._missing_manim_spec_resultkeeps both checks on one fail-closed message; disabled / non-manim skips are unchanged.timed_playand no spec → both checkspassed=False, details do not say skipped.Test plan
pytest tests/test_validate_timing_sync.py::test_hand_authored_paced_manim_without_spec_failspytest tests/test_validate.py::TestSubjectBeatCoverageValidate tests/test_validate_timing_sync.py::TestStoryEndpython3 scripts/check-complexity.py --base origin/main --paths src(PASS; helper CCN 1;_check_story_endCCN unchanged)benchmark_data/baseline.json(no clock/compile change)Made with Cursor