Fail closed when scene-compile leaves wait_segment YAML - #165
Merged
Conversation
…rejects. Upgrade row-level wait_segment to wait_word and write the spec back; add a corpus case so that path is benchmarked. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scene-compileupgradedwait_segmentonly in memory, thencompile_scene_classrejected the leftover YAML. Compile now writeswait_wordback and fails closed if it cannot.legacy_wait_segmentso the upgrade path is scored on the real_TimedSceneclock. Baseline updated only for that new case; existing scores are unchanged.compile_scene_classstill rejects leftoverwait_segment. Did not hand-editdocs/demosspecs.Test plan
test_retime_compile_spec_upgrades_wait_segment_yamltest_persist_upgraded_wait_segment_yaml_fails_closed_on_row_count_mismatchtest_legacy_wait_segment_upgrades_before_compiletest_compile_rejects_wait_segment(unchanged reject)docgen benchmarkgreen vs updatedbaseline.jsonMade with Cursor