fix: stop creating clock-racing scene-spec Manim dumps (#66) - #67
Merged
Conversation
Clamp FadeIn/page-fade run_times to the next wait_word so _TimedScene cannot dump the first board then freeze. FadeOut revealed boxes (not the parent VGroup), shorten the title write, and cover the cascade with unit tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes creation of garbage paced scenes (#66), not just post-hoc validation.
compile_scene_class(..., words=)clamps each FadeIn / page-faderun_timeso_TimedScene._clockcannot overshoot the nextwait_wordstartFadeOutrevealed boxes (not the parentVGroup, which could re-add siblings at full opacity)Writeshortened to1.0sso early spoken labels are not already in the past_TimedScene.timed_play(..., not_past=)defense in depthTest plan
pytest tests/test_scene_spec.py tests/test_scene_retime.py tests/test_manim_scene_support.pyscene-compile --retime+manimon sdlc demos 01/02 and confirm first-page boxes land on spoken beats without a frozen boardCloses #66
Made with Cursor