Mid-hold pulses and leftover title-clamp / overlap gates - #69
Open
jmjava wants to merge 2 commits into
Open
Conversation
Shrink the title Write so an early first wait_word is not skipped. Reject specs whose title buff / row / column gaps would collide, and boxes that clip the frame, before Manim runs. Flow pages grow the first node by default; page_transition: slide fades the prior board sideways. Co-authored-by: jmjava <jmjava@gmail.com>
After the first clock-safe Indicate, long subject-beat holds now schedule additional timed_wait + pulse/ring beats so the board does not sit still until the next wait_word. The last box uses the audio tail as its deadline. Validate fails a hold that would idle too long. Co-authored-by: jmjava <jmjava@gmail.com>
jmjava
marked this pull request as ready for review
August 15, 2026 03:28
Contributor
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #68. Two commits:
Title clamp, spec-geometry overlaps, slide pages — this landed on the previous branch after Clock-safe dwell and richer diagram motion #68 was squash-merged, so it never reached
main. TitleWriteis clamped against the firstwait_word; layout floors catch title-band / gap collisions before Manim; pagetransition: slideFadeOuts previous boxes with a left shift; flow pages auto-growthe first node.Mid-hold pulses — a single Indicate after a reveal still left long subject-beat holds frozen.
plan_hold_pulsesnow schedules additionaltimed_wait+Indicate/Circumscribebeats so the board does not sit still longer thanMAX_STATIC_HOLD(4s), always leavingDWELL_CLOCK_MARGINbefore the next spoken start. The last box uses the audio tail as its deadline.docgen validate/ generate-all preflight gainhold_idle_violations: a long freeze after the last pulse is a hard fail.Why
#68 made the first dwell clock-safe. Long holds (the intended subject-beat behavior) still looked stuck after that one pulse. This keeps fail-closed beat matching and does not invent labels.
Tests
ruff check src/ tests/pytest tests/ -q --tb=short— 391 passedConsumers should
pip installthis SHA and rundocgen scene-compile --retime(do not hand-edit generatedscenes.py).