Fail closed when --require-live skips because Ollama is down - #30
Merged
Conversation
Plain --live still exits 0; --require-live writes eval-runs/live-status.json and exits 2 so a skip cannot look like a quality pass. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--livestill printsSKIP liveand exits 0 when Ollama is down.--require-liveis the fail-closed path: exit 2 pluseval-runs/live-status.json{"skipped": true}.MAX_BYTES, leftover Document Copilot A8 and Claude A9 operator steps #13 unofficial-tag reject, A8/A9, downstairs GPU, and Halo 4 were not touched.Test plan
test_live_flag_skips_when_ollama_is_downstill asserts returncode 0test_require_live_exits_2_when_ollama_is_downasserts exit 2 and{"skipped": true}test_resolve_model_rejects_off_allowliststill passesMade with Cursor