Skip to content

Conversation

@javuto
Copy link
Collaborator

@javuto javuto commented Dec 19, 2025

Following up #754 to utilize the single YAML configuration file in the provision.sh deployment script

@javuto javuto requested a review from Copilot December 19, 2025 14:02
@javuto javuto added deployment Deployment related issues ⚙️ configuration Configuration related issues labels Dec 19, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR migrates the deployment provisioning script from using multiple JSON configuration files to a single YAML configuration file per service. The changes involve updating data types for port numbers from strings to integers across the codebase and modifying the deployment scripts to use yq for YAML manipulation instead of sed for JSON template substitution.

  • Updates port-related configuration fields from string to int type throughout the codebase
  • Replaces JSON configuration templates with YAML files and updates deployment scripts accordingly
  • Updates PostgreSQL and Go version references in provision script

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
tls.yml New YAML configuration file for osctrl-tls service with all service parameters
pkg/settings/settings.go Converts port integers to strings when storing in JSON settings
pkg/config/types.go Changes Port fields from string to int in YAML configuration structs
pkg/config/flags.go Updates CLI flags to use IntFlag instead of StringFlag for port parameters
deploy/provision.sh Refactors to use single YAML config file and yq tool; updates PostgreSQL/Go versions
deploy/lib.sh Simplifies configuration functions to use yq for direct YAML manipulation
deploy/config/service.json Removes JSON template file
deploy/config/redis.json Removes JSON template file
deploy/config/jwt.json Removes JSON template file
deploy/config/db.json Removes JSON template file
cmd/tls/main.go Updates port concatenation to use strconv.Itoa for integer conversion
cmd/cli/main.go Changes db-port flag from StringFlag to IntFlag
cmd/api/main.go Updates service listener to use integer port with strconv.Itoa
cmd/admin/main.go Updates service listener to use integer port with strconv.Itoa
cmd/admin/handlers/utils.go Adds string-to-int conversion for port values from settings

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@javuto javuto changed the title WIP: Use single YAML file in provision.sh Use single YAML file in provision.sh Dec 21, 2025
@javuto javuto merged commit 60e6ef1 into main Dec 21, 2025
55 checks passed
@javuto javuto deleted the provision-fix-yaml branch December 21, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

⚙️ configuration Configuration related issues deployment Deployment related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants