-
Notifications
You must be signed in to change notification settings - Fork 63
Use single YAML file in provision.sh
#757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR migrates the deployment provisioning script from using multiple JSON configuration files to a single YAML configuration file per service. The changes involve updating data types for port numbers from strings to integers across the codebase and modifying the deployment scripts to use yq for YAML manipulation instead of sed for JSON template substitution.
- Updates port-related configuration fields from string to int type throughout the codebase
- Replaces JSON configuration templates with YAML files and updates deployment scripts accordingly
- Updates PostgreSQL and Go version references in provision script
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| tls.yml | New YAML configuration file for osctrl-tls service with all service parameters |
| pkg/settings/settings.go | Converts port integers to strings when storing in JSON settings |
| pkg/config/types.go | Changes Port fields from string to int in YAML configuration structs |
| pkg/config/flags.go | Updates CLI flags to use IntFlag instead of StringFlag for port parameters |
| deploy/provision.sh | Refactors to use single YAML config file and yq tool; updates PostgreSQL/Go versions |
| deploy/lib.sh | Simplifies configuration functions to use yq for direct YAML manipulation |
| deploy/config/service.json | Removes JSON template file |
| deploy/config/redis.json | Removes JSON template file |
| deploy/config/jwt.json | Removes JSON template file |
| deploy/config/db.json | Removes JSON template file |
| cmd/tls/main.go | Updates port concatenation to use strconv.Itoa for integer conversion |
| cmd/cli/main.go | Changes db-port flag from StringFlag to IntFlag |
| cmd/api/main.go | Updates service listener to use integer port with strconv.Itoa |
| cmd/admin/main.go | Updates service listener to use integer port with strconv.Itoa |
| cmd/admin/handlers/utils.go | Adds string-to-int conversion for port values from settings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
provision.shprovision.sh
Following up #754 to utilize the single YAML configuration file in the
provision.shdeployment script