Conversation
There was a problem hiding this comment.
Pull request overview
Updates the repository’s pinned/default osquery version to 5.22.1 across build tooling, deployment configs, CI workflows, and the Go version constants used by osctrl components.
Changes:
- Bump
OsqueryVersionconstant (and related tests) from5.21.0→5.22.1. - Update deployment/configuration defaults (YAML configs, provision script, Dockerfile arg default, CI env,
.env.example) to5.22.1. - Refresh tool documentation/examples and the
fake_news_goversion list to reference5.22.1.
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tools/README.md | Updates example commands to use osquery 5.22.1 artifacts. |
| tools/fake_news_go/fake_news.go | Updates simulated osquery versions list to include 5.22.1. |
| tools/build-osctrl-pkg.sh | Updates usage example to 5.22.1. |
| tools/build-osctrl-deb.sh | Updates usage example to 5.22.1. |
| pkg/version/version.go | Bumps OsqueryVersion constant to 5.22.1. |
| pkg/version/version_test.go | Updates expected osquery version values in tests. |
| deploy/provision.sh | Updates provision default OSQUERY_VERSION to 5.22.1. |
| deploy/docker/dockerfiles/Dockerfile-osquery | Updates default OSQUERY_VERSION build arg to 5.22.1. |
| deploy/config/tls.yml | Updates configured osquery version + tables file path to 5.22.1. |
| deploy/config/api.yml | Updates configured osquery version + tables file path to 5.22.1. |
| deploy/config/admin.yml | Updates configured osquery version + tables file path to 5.22.1. |
| deploy/cicd/deb/generate-deb-package.sh | Updates default OSQUERY_VERSION used during DEB generation to 5.22.1. |
| .github/workflows/create_tagged_releases.yml | Updates CI env OSQUERY_VERSION to 5.22.1. |
| .github/workflows/build_and_test_pr.yml | Updates CI env OSQUERY_VERSION to 5.22.1. |
| .github/workflows/build_and_test_main_merge.yml | Updates CI env OSQUERY_VERSION to 5.22.1. |
| .env.example | Updates example OSQUERY_VERSION to 5.22.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OSCTRL_USER="${VARIABLE:-osctrl}" | ||
| OSCTRL_GROUP="${VARIABLE:-osctrl}" | ||
| WORKING_DIR="${VARIABLE:-/opt/osctrl}" | ||
| OSQUERY_VERSION="${VARIABLE:-5.21.0}" | ||
| OSQUERY_VERSION="${VARIABLE:-5.22.1}" | ||
| OSCTRL_VERSION="${VARIABLE:-0.0.0}" |
There was a problem hiding this comment.
In the DEB packaging flow, the installed osquery tables file name doesn't match the default/configured tablesFile path. deploy/config/*.yml (and pkg/config/flags.go default) point to ./data/<version>.json, but this script later copies the schema to /opt/osctrl/data/osquery-<version>.json. This will cause osctrl-admin to fail at startup when it tries to open the tables file. Align the filename (either copy to <version>.json or update the packaged config to reference osquery-<version>.json).
Support for osquery
5.22.1: https://github.com/osquery/osquery/releases/tag/5.22.1