Fix race condition in IncExecution and IncError#810
Merged
javuto merged 1 commit intoMay 12, 2026
Conversation
The previous implementation had a race condition where multiple goroutines could read the same value, increment it, and write back, causing lost updates. Before: 1. Thread A reads: executions = 5 2. Thread B reads: executions = 5 (same value) 3. Thread A updates: executions = 6 4. Thread B updates: executions = 6 (should be 7, increment lost) Fixed by using atomic database operations with gorm.Expr to perform the increment directly in SQL, avoiding the read-modify-write cycle. The new implementation uses: UPDATE distributed_queries SET executions = executions + 1 WHERE ... This ensures thread-safe atomic increments even under concurrent load. Fixes jmpsec#634
javuto
added
osctrl-tls
Collaborator
|
Fixes #634 Thank you! |
javuto
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous implementation had a race condition where multiple goroutines could read the same counter value, increment it, and write back, causing lost updates under concurrent load.
The read-modify-write cycle allowed this scenario:
Fixed by using atomic database operations with gorm.Expr to perform the increment directly in SQL:
This ensures thread-safe atomic increments even under concurrent load, matching the pattern used for IncExpected in the same file.