Name the position of an nth day of week - #719
Open
austek wants to merge 1 commit into
Open
Conversation
"0 59 10 ? 1/2 MON#1 *" read "at 10:59 every 2 months from month 1 Monday 1 of every month". The nth day of week printed its position as a bare number, and claimed "of every month" right after the month field had restricted it to every second month. Give the # and L forms their own phrasing, so they read "on the first Monday of the month" and "on the last Friday of the month" and no longer contradict a restricted month. Positions past the fifth, outside the Quartz range but reachable through the generic descriptor, fall back to the plain number. Field order is untouched, so the day of week still follows the month rather than leading the sentence as the report suggests. Fixes jmrozanec#126
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #126
0 59 10 ? 1/2 MON#1 *described asat 10:59 every 2 months from month 1 Monday 1 of every month. The nth day of week printed its position as a bare number, and claimedof every monthright after the month field had restricted it to every second month.The
#andLday of week forms now get their own phrasing:0 59 10 ? 1/2 MON#1 *0 0 0 ? * MON#30 0 0 ? * 6LNew base bundle keys
on_nth_day_of_week_x,on_last_day_of_week_xandnth_1..nth_5. Positions past the fifth are outside the Quartz range but reachable through the generic descriptor, so they fall back to the plain number.Field order is untouched, so the day of week still follows the month rather than leading the sentence as the report suggests.
Covered by
Issue126Testover all five positions, bothLspellings and the reported expression; the twoCronDescriptorTestassertions on the old wording are updated.