Update vendor-name and model name in S70otbr

[hlyi]

@jnilo1
This is a nice-to-have clean up. Please consider update after 4.0.0 release.

In S70otbr, the vendor-name and model-name are hardcoded to Lidl and Silvercrest. it will be great the settings can be derived based upon the board.

Thanks

[jnilo1]

Implemented — will land in v4.0.0

S70otbr no longer hard-codes --vendor-name Lidl / --model-name Silvercrest. It derives both from /proc/device-tree/model — the same board identity flash_efr32.sh already keys off for its board-match guard — defaulting to Lidl / Silvercrest (reference board unchanged) and using Sengled / Smart Hub G4 on the G4:

OTBR_VENDOR="Lidl"
OTBR_MODEL="Silvercrest"
case "$(cat /proc/device-tree/model 2>/dev/null)" in
    *Sengled*) OTBR_VENDOR="Sengled"; OTBR_MODEL="Smart Hub G4" ;;
esac
...
    --vendor-name "$OTBR_VENDOR" \
    --model-name "$OTBR_MODEL" \

Implementation note: it matches with a case glob on the file contents, not grep — the device's BusyBox has no tr to strip the model node's trailing NUL, and case "$(cat …)" sidesteps that (ash drops the NUL in the command substitution), so there's no dependency on how grep handles a NUL-bearing file.

The values land in the mDNS _meshcop._udp TXT records (vn / mn); once OTBR is up on the G4 you can confirm them from another host with avahi-browse -r _meshcop._udp.

Two open points:

• Is Smart Hub G4 the model string you want the G4 to advertise? It comes from your board.env BOARD_NAME ("Sengled Smart Hub G4 (E39-G8C)"); I can switch it to "Smart Hub G4 E39-G8C" or "E39-G8C".
• Same corner of the tree: the login banner (/etc/motd, /etc/version) went from "Lidl Zigbee Gateway" to "RTL8196E Gateway" — board- and role-neutral (correct for Zigbee, Thread, or router). The project name ("Lidl Silvercrest Gateway") is unchanged; this is only the login banner.

This is in for v4.0.0, which is gated on the issue #99 field soak — so likely a week or two out.

[hlyi]

@jnilo1 Thanks for implementing the change.

Is Smart Hub G4 the model string you want the G4 to advertise? It comes from your board.env BOARD_NAME ("Sengled Smart Hub G4 (E39-G8C)"); I can switch it to "Smart Hub G4 E39-G8C" or "E39-G8C"

Yes please do. I think it would be better to omit "G4", as it is advertised name at Amazon, but the label on the unit doesn't have it. What is on the label is "Smart Hub, Model: E39-G8C". So please consider "Smart Hub E39-G8C" or "E39-G8C".

[jnilo1]

Adopted — the G4 will advertise Sengled / E39-G8C

Taking the bare model number, as on the unit's label: the vendor field already carries "Sengled", so the pair reads "Sengled E39-G8C". "G4" is gone.

That is in the tree now, and lands with v4.0.0.

[hlyi]

@jnilo1 Great! Thanks for the update. I will close this thread.