🧹 Extract helper methods from run_terminal_review#10
Conversation
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Closing as stale — this PR was filed against a |
🎯 What: Extracted terminal reviewer MCP logic from
run_terminal_reviewinto a separate helper method_run_terminal_reviewer_session.💡 Why: To make
run_terminal_reviewmore readable and keep the server lifecycle management logic contained and separated. This avoids a single massive function that mixes high-level logic (e.g. parsing handoffs) with complex async resource management.✅ Verification: Ran format and lint checks which passed. Ran the unit tests (
pytest zenith/tests/ -m 'not e2e') and all relevant tests pass.✨ Result:
run_terminal_reviewis now much simpler and readable, and the complicated resource management is cleanly encapsulated.PR created automatically by Jules for task 4710921948287106728 started by @jnorthrup