Conversation
jocmp
changed the title
Owner
Author
|
wrong branch |
Replace OFFSET-based paging with SQLDelight's KeyedQueryPagingSource using published date as the keyset key. Benchmarks show ~8x faster paging across 13k articles (2s down to 250ms)
Remove offset-based all() and allNewestFirst/ allOldestFirst SQL from BySavedSearch and ByToday (kept in ByArticleStatus and ByFeed for tests). Add keyed pagination tests verifying correct order for both newest-first and oldest-first across 5 articles with page size of 2. Add read_later column, convert starred
jocmp
force-pushed
the
jc/keyed-paging
branch
3 times, most recently
from
7983466 to
2e5d310
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace OFFSET-based paging with SQLDelight's KeyedQueryPagingSource using published date as the keyset key.
Benchmarks show ~8x faster paging across 13k articles (2s down to 250ms)
Ref