Core: return peer's closing_signed msg if accepted #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to lightning spec, if the receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value so to transport this message we need to pass it inside MutualClosePerformed event, to be transported to the other peer. Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/DotNetLightning.Kiss
that referenced
this pull request
Jun 9, 2021
According to lightning spec, if the receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value so to transport this message we need to pass it inside MutualClosePerformed event, to be transported to the other peer. Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6 Upstream PR: joemphilips#168
Owner
|
LGTM |
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 9, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 10, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 10, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 25, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 25, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 26, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Jun 26, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/DotNetLightning.Kiss
that referenced
this pull request
Nov 22, 2021
According to lightning spec, if the receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value so to transport this message we need to pass it inside MutualClosePerformed event, to be transported to the other peer. Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6 Upstream PR: joemphilips#168
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Nov 22, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Nov 22, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Nov 23, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/DotNetLightning.Kiss
that referenced
this pull request
Nov 26, 2021
According to lightning spec, if the receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value so to transport this message we need to pass it inside MutualClosePerformed event, to be transported to the other peer. Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6 Upstream PR: joemphilips#168
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Dec 8, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
aarani
added a commit
to aarani/geewallet-notafork
that referenced
this pull request
Dec 14, 2021
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). * This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20210609-0920-git-c9731bf. (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168) Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Oct 16, 2022
Reply to peer's closing_signed if accepted; according to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109 (because this version includes a commit with the change needed to fix this bug, whose upstream PR is: joemphilips/DotNetLightning#168). Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6
knocte
pushed a commit
to nblockchain/geewallet
that referenced
this pull request
Oct 16, 2022
According to lightning spec, if closing_signed receiver agrees with the fee, it should reply with a closing_signed with the same fee_satoshis value, so other peer can create and broadcast the closing transaction as well. Before this commit geewallet wouldn't send anything back after agreeing to the proposed fee which would cause the closing_signed sender to get stuck waiting for a closing_signed back (and Frontend.Console would hang). This commit also upgrades DotNetLightning.Kiss to version 1.1.2-date20211122-1642-git-beb3109 (because this version includes a commit with the change needed to fix this bug, whose upstream PR is [1]). Source: https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6 [1] joemphilips/DotNetLightning#168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to lightning spec, if the receiver agrees with
the fee, it should reply with a closing_signed with the
same fee_satoshis value so to transport this message we
need to pass it inside MutualClosePerformed event,
to be transported to the other peer.
Source:
https://github.com/lightningnetwork/lightning-rfc/blob/master/02-peer-protocol.md#requirements-6