chore(auto): update flake inputs - #1738
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated flake update — repair report
Outcome: no code changes. Nothing in this update is broken, and no
deprecation warning in the logs originates in repo-owned code.
This branch is unmodified apart from the
flake.lockthe update itselfwrote.
git statusis clean.What the update actually changed
One input, and only one:
nur19d8cccacda571git show HEAD -- flake.lockis a three-line diff —lastModified,narHash,revon thenurnode. No other input moved; in particularnixpkgs did not move, so no NixOS/home-manager/nix-darwin option can
have been renamed or removed by this update.
mkRenamedOptionModulewarns and
mkRemovedOptionModulethrows, so a silently-dropped option isnot a failure mode available here.
nuris consumed in exactly two places, both package-level:flake/setup.nix:27—inputs.nur.overlays.default, which is purelyadditive (it introduces the
pkgs.nurattribute and overrides nothing).users/profiles/firefox.nix:12—pkgs.nur.repos.rycee.firefox-addons.It ships no NixOS modules into this repo, so there is no option surface
for it to break.
What I verified
nix run .#world -- check— exit 0, 52 ✅, no errors.nix run .#world -- lint— exit 0.checkrun is identical to the supplied.ci-check.log, down to the same nixpkgs store path(
fmasn49f010z71q951x7l7cbyld8p4fl) inside theoptions.jsonwarnings — confirming nixpkgs is unmoved and no warning is new.
checkskips builds, and these add-ons are
fetchurlpins that reach realhosts (
eris,antares,cygnus,neptune) throughusers/profiles/workstation.nix. Evaluation cannot catch a deadadd-on URL or a stale hash — only a build can. All six fetch and build:
tridactyl-1.25.0,ublock-origin-1.74.0,privacy-badger-2026.8.7,duckduckgo-privacy-essentials-2026.8.6,react-devtools-6.1.1,adsum-notabs-1.2resigned1. This is the one place the update couldhave bitten a machine without any gate noticing, and it does not.
Why I changed nothing for the deprecation warnings
Every warning in
.ci-check.logcomes from a flake input, not from thisrepo. I checked rather than assumed:
stdenv.isDarwin/stdenv.isLinuxdeprecated — no.nixfile inthis repo uses the bare form. Grepped for
stdenv.(isDarwin|isLinux|isAarch64|isx86_64|isMusl|isStatic): zeromatches. It comes from inside inputs.
devenv-up/devenv-testpackage deprecated — emitted by thedevenv input's own
flake-module.nix. The only mentions in this repo(
flake/github-actions.nix:12,flake/buildkite-pipeline.nix:11) areCI matrix skip lists, not definitions.
rocksdbnestedbuildInputs— inside the tuwunel input.options.json/builtins.derivationwithout proper context —input-owned.
rekey.hostPubkeyunset fortestandinstaller— intentionaland self-documenting; agenix-rekey's own message says this is expected
until the host is first deployed and its pubkey read back.
None of these is fixable with a small local diff. Each would require
changing an input, and "fixing" any of them in this repo would mean
deleting or rewriting something that is not the cause — which is exactly
the failure mode this process is meant to avoid.
Needs a human
1. Deprecated
filterin the update tooling —misc/gh-release-update.nuThis is the only deprecation warning in the logs that is genuinely
repo-owned. It appears in
.ci-update.log:I did not touch it, by policy, and I think the policy is right here.
The parser reports only the first occurrence (line 10), but there are
three call sites — lines 10, 26 and 36. Lines 26 and 36 are the same
expression, and it is the one that decides which release gets pinned:
That predicate selects the version that ends up in a URL in
flake.nixfor VictoriaLogs and the two Grafana datasource plugins. A wrong choice
here — picking a prerelease, or the wrong element of
$releases—still evaluates, still builds, still merges, and pins the wrong version
on every host. A green build proves nothing about it.
filterstill works;the script ran correctly on this update, resolving 1.51.1 / 0.31.0 /
0.25.2. This is a warning, not a break. nushell tracks top-level
nixpkgs, which did not move in this update — so this warning is not new,
it recurs on every run.
wherewith aclosure-from-variable is exactly equivalent to
filterfor thesepredicates, and whether the fix should change one call site or all
three. Line 10 (
str contains) is a different shape from lines 26/36and may want a different replacement. Verifying that needs a run against
the live GitHub API with the resulting pins inspected by eye — not
something a passing build can confirm.
2. Pre-existing latent issues — not from this update, listed for context only
Neither is a regression and neither is in scope for a repair run; I am
surfacing them because they are invisible to CI, which gates only on
lint,checkand the x86_64-linux package build.world checkreportsomitted these incompatible systems: aarch64-darwin, aarch64-linux, x86_64-darwin, so--all-systemsfailures never reach the gate. Under
--all-systems,flake/packages.nixnoctaliabreaks on darwin — noctalia shipslinux-only outputs. Its neighbours
zwift/persway/weztermallcarry
stdenv.hostPlatform.isLinuxguards with apkgs.hellofallback;
noctaliawas never given one. Adding a guard means choosinga fallback, which is a decision, not a repair.
flake.nixstill listsx86_64-darwininsystemsalthough nixpkgs26.11 dropped it. No real host is affected — both darwin hosts are
aarch64-darwin— so removing it is a cleanup with a blast radius, nota fix this branch needs.