fix: production hardening v3 — 5 critical issues - #23
Merged
Conversation
1. Snapshot path traversal: validate filename in /snapshots/<filename> 2. Web server health check: monitor thread, restart + notify on crash 3. Event log disk errors: wrap writes in try/except OSError 4. Snapshot disk errors: catch OSError, warn on save failure 5. Fix pyproject.toml: add missing sounddevice dependency
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/snapshots/<filename>— reject..and/web_thread.is_alive()in main loop, auto-restart + notify on crash (extractedstart_web_server()helper to avoid duplication)log_event()writes in try/except OSError — dropping an event beats crashing the monitorsave_snapshot()in try/except OSError, print warning on failuresounddevice>=0.4to required dependencies (audio is on by default)7 new tests covering all fixes. 202 total tests passing.
Test plan
python3 -m pytest tests/ -v— 202 passed/snapshots/../etc/passwdreturns 400