feat(json_conv): Specify the type as the narrower Yojson.Basic.t - #87
Merged
Conversation
Owner
|
Thanks! 🙏 Merged ✅ |
johnyob
added a commit
to johnyob/opam-repository
that referenced
this pull request
Jul 23, 2026
CHANGES: - feat(renderer): add boxing to trailing labels ([johnyob/grace#92](johnyob/grace#92)) - fix(renderer): print unicode and ansi-styled snippets as correct lengths ([johnyob/grace#88](johnyob/grace#88)) - feat(renderer): add boxing to multi-line labels ([johnyob/grace#88](johnyob/grace#88)) - feat(json_conv): use `Yojson.Basic.t` ([johnyob/grace#87](johnyob/grace#87)) - feat(json_conv): add `Grace_json_conv` for conversion to Yojson ([johnyob/grace#84](johnyob/grace#84)) - fix(core): dont catch `Sys_error` in `Source.length` if the fail doesn't exist ([johnyob/grace#81](johnyob/grace#81)) - feat(renderer): support configurable contextual lines ([johnyob/grace#74](johnyob/grace#74))
johnyob
added a commit
to johnyob/opam-repository
that referenced
this pull request
Jul 24, 2026
CHANGES: - feat(renderer): add boxing to trailing labels ([johnyob/grace#92](johnyob/grace#92)) - fix(renderer): print unicode and ansi-styled snippets as correct lengths ([johnyob/grace#88](johnyob/grace#88)) - feat(renderer): add boxing to multi-line labels ([johnyob/grace#88](johnyob/grace#88)) - feat(json_conv): use `Yojson.Basic.t` ([johnyob/grace#87](johnyob/grace#87)) - feat(json_conv): add `Grace_json_conv` for conversion to Yojson ([johnyob/grace#84](johnyob/grace#84)) - fix(core): dont catch `Sys_error` in `Source.length` if the fail doesn't exist ([johnyob/grace#81](johnyob/grace#81)) - feat(renderer): support configurable contextual lines ([johnyob/grace#74](johnyob/grace#74))
johnyob
added a commit
to johnyob/opam-repository
that referenced
this pull request
Jul 27, 2026
CHANGES: - feat(renderer): add boxing to trailing labels ([johnyob/grace#92](johnyob/grace#92)) - fix(renderer): print unicode and ansi-styled snippets as correct lengths ([johnyob/grace#88](johnyob/grace#88)) - feat(renderer): add boxing to multi-line labels ([johnyob/grace#88](johnyob/grace#88)) - feat(json_conv): use `Yojson.Basic.t` ([johnyob/grace#87](johnyob/grace#87)) - feat(json_conv): add `Grace_json_conv` for conversion to Yojson ([johnyob/grace#84](johnyob/grace#84)) - fix(core): dont catch `Sys_error` in `Source.length` if the fail doesn't exist ([johnyob/grace#81](johnyob/grace#81)) - feat(renderer): support configurable contextual lines ([johnyob/grace#74](johnyob/grace#74))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was a simple mistake by me in #84, I often get mixed up between the various Yojson modules and thought 'Safe' was the smallest one, but it is not, 'Basic' is.
This makes the type easier to consume downstream.