fix: remove extra space in inline label lines - #98
Merged
Conversation
shonfeder
pushed a commit
to ocaml/opam-repository
that referenced
this pull request
Aug 6, 2026
CHANGES: - fix(renderer): adjust margin for messages near end of line ([johnyob/grace#97](johnyob/grace#97)) - fix(renderer): remove extra space in trailing labels ([johnyob/grace#98](johnyob/grace#98)) - fix(renderer): error recovery on invalid UTF-8 strings ([johnyob/grace#99](johnyob/grace#99))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I spotted this in #97 (comment) but it turns out it was also impacting the existing tests.
Basically, by adding a space in pp_trailing_label, the start location of all boxes inside the message start 1 character too far over for inline labels. E.g., even though it is in a
<v2>,new line of error1was 3 columns indented relative toe1:.Instead, we can print that space after the carets and before the inline label and get the expected behavior