Are default air settings not active?

[dmenne]

I can manually call format my qmd. See #144

With my default air settings, the a=3 is changed to a = 3. As I understand, panache forwards to air - are the default settings not active?

[jolars]

It does, but you have to enable it first in panache.toml:

[formatters]
r = "air"

[dmenne]

• For consistency, I updated air to the versions @jtlandis is using.
• I know that panache.toml is used, because lint-rules are honored and linting works
• Using [formatters.air] as above, but removing it does not change anything.
• Format on save works partially

```{r,warnings = FALSE, echo = FALSE}
a=1

becomes:

```{r,warnings = FALSE}
#| echo: false
a=1

Why is warnings not converted to label?
Why no spaces for a=1?

[jolars]

Only a hardcoded set of options are converted. Does warnibgs work too? I thought it was just warning.

Can you try replacing {} with x.R in the args config for air above?

[dmenne]

I thought it was just warning.

Sorry for the noise, you are right and it works now for this one.

However,a=1 still is uncorrected.

Can you try replacing {} with x.R in the args config for air above?

I replaced it verbatim as you mentioned, but I am not sure if I should write "index.R" because x is meant as a placeholder

[jolars]

The file name doesnt matter as long as it ends in .R. Sorry about this. I'm away from my computer right now but ill publish a release on Monday that i think should fix these issues.

[jolars]

Is everything working for you now, @dmenne? I made a lot of updates to the release strategy recently. I hope nothing broke 🤞

[dmenne]

Looks like the issues are still there

• panache 2.33.0
• uninstalled/reinstalled panache extension to be safe
• cross-reference label missing correctly reported panache(undefined...)
• explicit reformat of text works ok, no reformat on safe. Checked Default Formatter and Format on save to be on for folder, workspace and user; somewhat duplicate, but I wanted to be sure it is not some accesibility problem
• a=3 not reformatted; this is active for R files

[dmenne]

I just noted there is a 2.33.1; will check immediately

[jolars]

Thanks for the update! Hm, reformat on save I think should work just fine. Have you double-checked that panache is the default formatter for qmd files?

[dmenne]

Checked 2.33.1. No change for described issues.

I just noted that I have 2 panache.exe, one in C:\tools (manually moved there by me) and one I C:\Users\Dieter.cargo\bin, but they have exactly the same size 12163072 Bytes

[dmenne]

Ok, I see, the manually C:\tools is the github build and takes priority. The cargo-version is not required (or is it?)

[dmenne]

This reply overlapped with you question.

settings.json: Was

{
  "editor.formatOnSave": true,
  "editor.defaultFormatter": "jolars.panache",
  "[r]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "Posit.air-vscode"
  },
  "[quarto]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "quarto.quarto"
  }
}

Could have been the culprit, because special goes before general. Changed to

{
  "[r]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "Posit.air-vscode"
  },
  "[quarto]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "jolars.panache"
  }
}

But, too bad, no change. Even after restart. Also added

  "[qmd]": {
    "editor.formatOnSave": true,
    "editor.defaultFormatter": "jolars.panache"
  },

as third entry, no change. Something seems to happen on save, because a trailing space is remove in r code, so probably some other formatter has pirated it.

[jolars]

When you select "Format Document With…", what does it say?

Can you also try enabling Panache trace/output and confirm "Formatting request" appears?

[dmenne]

Explicit panache format index.cmd does not make any corrections

Can you also try enabling Panache trace/output and confirm "Formatting request" appears?

I do not know where to do this, so I tried Ctrl-Shift P. Surprisingly, not a single entry for Panache. Is that ok, or should there be one?

[jolars]

[dmenne]

Minimal example with log when file is saved. Will try again tomorrow

[dmenne]

panache 2.33.1, I always check that to be sure. Will try #f6e39f1

[dmenne]

Will try again tomorrow

[dmenne]

Screenshot just now. Is that the version of the extension which is behind? 2.31.0?

[jolars]

The version is not corect, but last updated looks right. Hm. Maybe worth trying to set the path to panache explicitly too. Maybe the problem is that auto-updating failed and you have an auto-downloaded panache binary that's Positron-local that's taking precedence.

Just to verify: you're seeing panache 2.33.1 as the version of panache when your running panache --version inside the Positron terminal?

[dmenne]

panache 2.33.1 -->> yes.

[dmenne]

No way to get a more recent marketplace extension, I tried multiple install/reinstalls.

[dmenne]

"panache.serverEnv": {
"PATH": "C:\Users\Dieter\.local\bin;${env:PATH}"
}

in extension.json or settings?

[dmenne]

Hesitating to use this,

   "panache.serverEnv": {
     "PATH": "C:\\Users\\Dieter\\.local\\bin;${env:PATH}"
   }

because my manually installed one is in

which panache.exe
/c/tools/panache.exe

Or are subfolders required?

Beeing a rust noob: can I directly install the github version you mentioned with cargo?

[jolars]

You can install the latest panache binary with

cargo install panache

What is your version of panache right now? if you run panache --version?

[dmenne]

cargo install panache
    Updating crates.io index
     Ignored package `panache v2.33.1` is already installed, use --force to override

[dmenne]

To be sure that is is not a special settings problem of air for a=3 , I also tried

if (a == 3) print("Hello") else print("world")

Which is formatted with { } in .R, but nothing happens here.

[jolars]

Another thing to try its to set

[formatters.air]
cmd = "path/to/air"

And see if that works

[dmenne]

Yesterday the VSIX server was down, nothing worked and I needed some time to find out what is wrong. Totally deinstalled Positron, hopefully found all caches etc. New install of everything this morning.

• Manually installed panache is 2.34.0
• Reinstalled extension. When I deactivated the manuall installed one, I get 2.33.1, so that one is not yet updated
• Switching back to 2.34 as priority
• Air is 0.9.0
• Checked settings, Panache trace verbose
• Panache correctly reports "has no label"
• Panache (or whoever) reformats long text strings.
• No effect on a=3 on save
• No effect on a=3 with panache format index.cmd (1 file unchanged)

Panache log

....

[Trace - 8:43:11 AM] Sending request 'textDocument/codeAction - (6)'.
Params: {
    "textDocument": {
        "uri": "file:///c%3A/tmp/index.qmd"
    },
    "range": {
        "start": {
            "line": 6,
            "character": 3
        },
        "end": {
            "line": 6,
            "character": 6
        }
    },
    "context": {
        "diagnostics": [
            {
                "range": {
                    "start": {
                        "line": 6,
                        "character": 3
                    },
                    "end": {
                        "line": 6,
                        "character": 6
                    }
                },
                "message": "Executable code chunk has no label; add `#| label: ...`",
                "code": "missing-chunk-labels",
                "severity": 2,
                "source": "panache"
            }
        ],
        "only": [
            "quickfix"
        ],
        "triggerKind": 1
    }
}

[Trace - 8:43:11 AM] Received response 'textDocument/codeAction - (6)' in 10ms.
Result: []

My sample

---
title: "Test Panache"
---

## Quarto

```{r}
a=3
```

[jolars]

What is your panache.toml right now? Maybe you can try to invoke air through stdin:

[formatters]
r = "air"

[formatters.air]
stdin = true
args = ["format", "--stdin-file-path", "{}"]

I'll push a new version of panache today with better logging, so we can understand what's failing. Thanks for your patience!

[jolars]

Maybe also try:

[formatters.air]
cmd = "exact/path/to/air"

[jolars]

Where is air located, anyway? C:\\Users\\Dieter\\.local\\bin\\air.exe?

[dmenne]

I reinstalled Panache extension, but it is still 2.31.0. Is there any use in trying to debug this when the extension is "published 1 month ago, last released 2 weeks ago"?

Still getting the "Panache binary download failed" popup "Falling back to panache". But that's the extension, which is Methusalem.

Just tested: format.wrap="sentence". Works like a charm on text.

Removed all air.exe (there were multiple). Reinstalled air, it is the only one now in the mentioned folder, version 0.9.0

[formatters]
r = "C:/Users/Dieter/.local/bin/air.exe"

No effect on R-chunks, called on save, text formatting ok.

[Trace - 10:00:00 AM] Sending request 'textDocument/documentLink - (52)'.
Params: {
    "textDocument": {
        "uri": "file:///c%3A/tmp/index.qmd"
    }
}


[Trace - 10:00:00 AM] Received response 'textDocument/documentLink - (52)' in 5ms.
No result returned.

[dmenne]

Works!

• Do not tick download binary in settings (looks like this is the main point, because of the error on download)
• use explicit path (not required, but I wanted to be sure)

Thanks for your tremendous help!

This is already in your documentation.

{
"panache.downloadBinary": false,
"panache.commandPath": "/usr/local/bin/panache"
}

[jolars]

Im so glad it finally worked! So it was the binary all along. Okay, great!

[dmenne]

• Downloaded and installed 2.35.0
• Formatting works
• Switched downloadBinary to true: No more message.

Thanks for your work.

Just a note: Extension finally is also up to date, but 2.34.1, "last released 48 minutes". Strange one-behind scheme (by MS?)

[jolars]

Great! Problem seems to have been that I had pinned a too high dependency on the vscode engine in 2.32, which seems to have caused Positron to drop all subsequent releases.

[jolars]

Just a note: Extension finally is also up to date, but 2.34.1, "last released 48 minutes". Strange one-behind scheme (by MS?)

I have decoupled extension releases from the binary. Initially I kept them in lock-step but it was causing users to have to continuously update the extension even though nothing in the extension itself changed. You still get automatic version updated for the CLI client if there are such.