Fix readline ignores Ctrl-C on macOS (#1347) #1348
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- On macOS, you cannot cancel out of search ('/') using
Ctrl-C (SIGINT), but rather must press <Enter> (and
perform the search) to return to the main view.
- This commit partially reverts ea43f8b, “Fix segfaults
with readline 8.0” (and associated Issue, “Piping to
tig segfaults on exit” jonas#893), but just for macOS builds.
Collaborator
|
Dupe of #1342 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed PR for #1347
On macOS, you cannot cancel out of search ('/') using Ctrl-C (SIGINT), but rather must press (and perform the search) to return to the main view.
This commit partially reverts ea43f8b, “Fix segfaults with readline 8.0” (and associated Issue, “Piping to tig segfaults on exit” Piping to tig segfaults on exit #893), but just for macOS builds.