Enforce the aggregate production quality gate in CI#44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #37
What changed
Production qualityGitHub Actions job that runsnpm run quality:productionon every applicable workflow run.CyclomaticComplexityplusNPathComplexityfrom the pinnedtypescriptpolicy before enforcing the full report.Why
Per-unit remediation is complete, but CI did not yet enforce the complete production surface. This final gate prevents a clean unit from concealing findings elsewhere and keeps policy selection auditable even when the report has zero findings.
Validation
npm run quality:production— 8 units, required complexity rules, zero findingsdeno test --frozen=false --allow-all— 180 passed