ci: bump github/codeql-action/init from 4.37.3 to 4.37.8 - #620
ci: bump github/codeql-action/init from 4.37.3 to 4.37.8#620dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [github/codeql-action/init](https://github.com/github/codeql-action) from 4.37.3 to 4.37.8. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@e4fba86...db488dd) --- updated-dependencies: - dependency-name: github/codeql-action/init dependency-version: 4.37.8 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
|
🚀 Website Preview
Preview has been cleaned up as the PR was closed. |
wbreza
left a comment
There was a problem hiding this comment.
The SHA pin is authentic and correctly scoped, but bumping init alone leaves autobuild and analyze on 4.37.3 and CodeQL fails.
What stood out
- Verified, immutable action pin —
db488ddeis exactly the commit the upstreamv4.37.8annotated tag dereferences to, on the officialreleases/v4branch, so the SHA-pinning posture holds. - Partial upgrade breaks the job —
initmoves to 4.37.8 whileautobuildandanalyzestay on 4.37.3; the Analyze check on this PR already fails at autobuild before any SARIF is produced. - Split across three Dependabot PRs — #621 and #622 carry the autobuild and analyze halves, so merge order decides whether
mainlands in a mixed-version state.
Top issues
- [F-001] CodeQL job fails: init on 4.37.8, autobuild and analyze still on 4.37.3 —
.github/workflows/codeql.yml:40 - [F-002] Merging this PR alone leaves the workflow mixed-version —
.github/workflows/codeql.yml:40
Cross-cutting
- [F-003] Pin comment
# v4is less precise than the repo convention (process) — other pinned actions record the exact release, e.g.# v7.0.0on line 34.
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[F-001] This bump moves init to db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 (v4.37.8), but autobuild (line 45) and analyze (line 48) remain pinned to e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 (v4.37.3). CodeQL requires every step in the job to run the same version, and the mismatch is a hard failure, not a warning.
The Analyze check on this PR fails at the Autobuild step:
We were unable to automatically build your code. Please replace the call to the autobuild action
with your custom build steps. Loaded a configuration file for version '4.37.8', but running version '4.37.3'
Analysis aborts before any SARIF is uploaded, so the branch gets no CodeQL results at all. The last 10 CodeQL runs on main all succeeded with the three steps aligned at 4.37.3, which confirms the skew is introduced here rather than pre-existing.
Fix: repoint all three CodeQL steps to db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 in a single change.
- name: Autobuild
uses: github/codeql-action/autobuild@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4.37.8|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[F-002] Dependabot split this upgrade across three PRs, one per action path:
- ci: bump github/codeql-action/init from 4.37.3 to 4.37.8 #620 (this PR) —
codeql-action/init - ci: bump github/codeql-action/autobuild from 4.37.3 to 4.37.8 #621 —
codeql-action/autobuild - ci: bump github/codeql-action/analyze from 4.37.3 to 4.37.8 #622 —
codeql-action/analyze
Because the three steps must share a version, merging any subset leaves main in a mixed-version state and breaks CodeQL there the same way it is broken on this branch. Merging this one first is the worst case: main starts failing immediately and stays failing until #622 lands.
Fix: merge all three in one batch, or fold the autobuild and analyze pins into this PR and close #621 and #622 as superseded.
|
|
||
| - name: Initialize CodeQL | ||
| uses: github/codeql-action/init@e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81 # v4 | ||
| uses: github/codeql-action/init@db488ddef3bf6cb639b32c2e9a7c0a7ea8271d28 # v4 |
There was a problem hiding this comment.
[F-003] The trailing comment records # v4 — a floating major — rather than the exact release being pinned. The rest of the repository records the precise version alongside the SHA, including the step directly above this one:
.github/workflows/codeql.yml:34—actions/setup-go@b7ad1da... # v7.0.0.github/workflows/ci.yml:43—# v7.0.1.github/workflows/ci.yml:53—# v6.1.0.github/workflows/release.yml:499—# v4.1.2
The imprecise comment predates this PR on the CodeQL steps, so this is carried forward rather than introduced, but it hides which release was actually audited and makes the skew in F-001 invisible to a reader scanning the file. Recording # v4.37.8 on all three CodeQL steps would make the mismatch obvious at a glance.
|
Superseded by #624. |
Bumps github/codeql-action/init from 4.37.3 to 4.37.8.
Release notes
Sourced from github/codeql-action/init's releases.
Changelog
Sourced from github/codeql-action/init's changelog.
... (truncated)
Commits
db488ddMerge pull request #4102 from github/update-v4.37.8-9ee088e131845f5bUpdate changelog for v4.37.89ee088eMerge pull request #4080 from github/henrymercer/studious-giggle1aef003Address review feedback on overlay disk flags508b83bMerge main into overlay minimum disk feature branchd97b342Merge pull request #4098 from github/mbg/permission-error-as-configuration-error47fa622MakeEACCESaConfigurationError45693ccRefactorENOSPCcheck intoisDiskConfigurationErrorfunctionc2fd8f5Merge pull request #4081 from github/mario-campos/version-cache-to-diskc56f48eLog unexpected conditions during caching CLI outputDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)