fix(release): keep cosign classic signature format#323
Merged
Conversation
After removing --oidc-issuer, cosign got further but failed with 'create bundle file: open : no such file or directory': the newer cosign defaults to --new-bundle-format, which ignores --output-signature/--output-certificate and needs a --bundle path. Rather than switch to a single .bundle (which would break the signature verification in install.sh and install.ps1 that download separate .sig and .pem files), disable the new bundle format so the classic .sig/.pem artifacts are produced as before. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 524cf702-8922-4cfd-b23f-4069b734e09b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After #322 removed
--oidc-issuer, the release got past the first cosign error but failed at signing with:The newer cosign defaults to
--new-bundle-format, which ignores--output-signature/--output-certificateand instead wants a--bundlepath. With none provided, it tried to write a bundle to an empty path and failed.Fix
Add
--new-bundle-format=falseso cosign keeps its classic output: separate.sigand.pemfiles.This is deliberate rather than switching to the single-file bundle, because both
install.shandinstall.ps1verify the checksums withcosign verify-blob --signature <checksums>.sig --certificate <checksums>.pem. Adopting the bundle format would require changing both install scripts and would break verification for the existing release format. A code comment documents why.Follow-up
The
v0.14.0tag (re-created by the second failed run, still no release attached) will be deleted and the Release workflow re-triggered after this merges.