fix(pprof): add read/write timeouts to diagnostic HTTP server#150
Merged
Conversation
The pprof HTTP server used http.ListenAndServe with no timeouts, leaving it vulnerable to slowloris-style connection exhaustion (CWE-400). Replace with an explicit http.Server that sets ReadHeaderTimeout, ReadTimeout, WriteTimeout, and IdleTimeout. The server remains opt-in (--pprof flag) and bound to 127.0.0.1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The pprof diagnostic HTTP server used http.ListenAndServe with the default
http.Server settings, which means no read or write timeouts. A malicious
local process could exhaust the server's connection pool via a slowloris-style
attack (CWE-400, CVSS 3.1 Low — requires local access).
Changes
Replaced the bare http.ListenAndServe call with an explicit http.Server
that sets:
The server remains opt-in (requires --pprof flag) and bound to 127.0.0.1.
CWE Reference